fix(ci): upload example assets only for releases - #1608
Draft
mrousavy wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example Release workflows currently build successfully on pull requests, then try to upload a release asset without a release upload URL. Restrict asset uploads to published release events and use the GitHub CLI in place of the unmaintained upload action. Published releases keep the same asset names; pull requests still exercise the builds and packaging.
Validated both workflows with actionlint and executed the exact upload scripts against temporary APK/ZIP fixtures with a stubbed GitHub CLI, checking renamed assets and arguments. No release was published. CI runs for this draft are intentionally cancelled to conserve Actions minutes.