Skip to content

Fix chronic CI build blockers in NVMe zone/completion paths and LLM Vulkan dependency lane - #6222

Merged
makr-code merged 2 commits into
developfrom
copilot/fix-chronic-build-failures-again
Sep 1, 2026
Merged

Fix chronic CI build blockers in NVMe zone/completion paths and LLM Vulkan dependency lane#6222
makr-code merged 2 commits into
developfrom
copilot/fix-chronic-build-failures-again

Conversation

Copilot AI commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Pull Request

For EPIC-branch workflow PRs, use .github/PULL_REQUEST_TEMPLATE/epic-branch-flow.md.
This applies to both feature/* -> epic/* and epic/* -> develop integration PRs.

Target Version (Required)

Target Version: v2.4.1

Build stability regressions were blocking normal development flow on develop; this is a non-breaking bug-fix/hardening change appropriate for the current stable patch line.


Description

The chronic-error aggregation pointed to repeated CI build blockers in the last 24h, with failures concentrated in compile-time breakages and missing build dependencies.
This PR applies minimal, targeted fixes to restore deterministic build behavior without changing feature scope.

  • CI-derived failure focus

    • Addressed the concrete blockers surfaced by recent failing build lanes (undeclared identifiers in storage runtime code; missing Vulkan headers in LLM inference lane).
  • Runtime compile fix (src/storage/nvme_manager.cpp)

    • Restored parameter identifiers that were accidentally commented out but still referenced in logic:
      • pollCompletions(..., min_complete)
      • resetZone(zone_offset)
      • finishZone(zone_offset)
      • getZoneWritePointer(zone_offset) const
    • This resolves hard compile failures in NVMe completion/zone operations.
  • LLM inference workflow dependency hardening

    • Added libvulkan-dev to the dependency install set in:
      • .github/workflows/build-llm-inference.yml
    • This removes the recurring vulkan/vulkan.h missing-header failure in that CI lane.

Example of the core compile fix:

int NVMeManager::pollCompletions(std::vector<NVMeIOResult>& results,
                                  uint32_t min_complete) {
    // ...
    if (min_complete > 0) {
        // wait for at least min_complete completions
    }
}

Linked Issues

Handled automatically by the system.

Type of Change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Refactoring (non-breaking)
  • Documentation
  • Breaking change (requires MAJOR version bump — see VERSIONING.md)
  • Security fix
  • Other: CI/build dependency hardening

Breaking Change Checklist

  • MAJOR version bump planned in VERSION and CMakeLists.txt
  • Migration guide added in docs/migration/
  • Announcement prepared for GitHub Discussions (≥ 2 weeks before release)
  • CHANGELOG ### Removed / ### Changed section updated

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Benchmarks run (if performance-sensitive change)

Security Tiering Impact (Required for Runtime Changes)

  • Impacted tier(s):

    • T0 Trusted Core
    • T1 Security & Platform Services
    • T2 Data Plane Engines
    • T3 Interface & Protocol Edge
    • T4 Managed Extension Runtime
    • T5 Plugin Boundary
    • N/A (docs-only / non-runtime)
  • Trust-boundary crossings documented in PR description (example: T3 -> T2, T5 -> T4 brokered call)

  • Boundary controls validated for affected T3/T4/T5 paths (AuthN/AuthZ, validation, rate limits, audit)

  • Boundary-focused tests added/updated or explicit N/A rationale provided

  • If trust level/privilege increased, security maintainer approval is attached

📚 Research & Knowledge (wenn applicable)

  • Diese PR basiert auf wissenschaftlichen Paper(s) oder Best Practices?
    • Falls JA: Research-Dateien in /docs/research/ angelegt?
    • Falls JA: Im Modul-README unter "Wissenschaftliche Grundlagen" verlinkt?
    • Falls JA: In /docs/research/implementation_influence/ eingetragen?

Relevante Quellen:

  • Paper:
  • Best Practice:
  • Architecture Decision:

AI-Generated Code (KI-generierter Code)

  • Symbol-Referenzen mit GetSymbolReferences_CppTools geprüft (siehe .github/instructions/cpp-language-service-tools.instructions.md)
  • Keine rohen Pointer und kein new/delete ohne explizites Review eingeführt
  • RAII und Exception-Safety für neue/angepasste Pfade geprüft
  • Keine unnötig komplexen KI-Abstraktionen eingeführt
  • Performance-Metriken geprüft, falls Hotpath betroffen

AI Review Workflow (Required for AI-assisted PRs)

  • Findings-first review performed with .github/prompts/pr-diff-findings-review.prompt.md
  • Security hardening review performed for security-sensitive/runtime changes with .github/prompts/security-hardening-review.prompt.md (or N/A documented)
  • API impact review performed for API/contract changes with .github/prompts/api-change-impact-review.prompt.md (or N/A documented)
  • All Critical/High findings are resolved or explicitly accepted with rationale in PR description
  • Residual risks and follow-up actions documented in PR description
  • Severity policy applied according to .github/copilot/REVIEW_SEVERITY_POLICY.md

High-Finding Exception Record (only if High is accepted)

  • High-finding exception claimed in this PR

  • Finding reference:

  • Maintainer approver:

  • Mitigation in current release:

  • Target fix milestone:

  • Tracking issue:

  • Validation evidence:

Release Readiness Gate (Required for release-scoped changes)

  • Release readiness reviewed with .github/prompts/release-readiness-check.prompt.md for branch transition scope
  • Branch governance validated against BRANCHING_STRATEGY.md and RELEASE_STRATEGY.md
  • Versioning/changelog impact validated against VERSIONING.md and CHANGELOG.md

Checklist

  • Code follows project style guidelines (clang-format / clang-tidy)
  • Self-review completed
  • Documentation updated (if needed)
  • CHANGELOG.md updated under [Unreleased]
  • No new warnings introduced
  • Security-sensitive paths reviewed by security maintainer (if applicable)

Scanner and IntelliSense Gates

  • IntelliSense/Compiler: no new errors in changed files
  • clang-tidy/cppcheck: no new high-risk findings in changed files
  • Gap Scanner: no new critical findings in categories security, input_validation, query_correctness, distributed_consistency, concurrency, memory
  • Gap Scanner: no new high findings in the same categories (or explicitly approved)
  • Gap Scanner delta report attached (baseline vs current), not only absolute totals
  • New unknown scanner findings triaged (fixed, re-categorized, or justified)

Copilot AI lite review requested due to automatic review settings September 1, 2026 05:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI linked an issue Sep 1, 2026 that may be closed by this pull request
Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix chronic build failures in CI workflow Fix chronic CI build blockers in NVMe zone/completion paths and LLM Vulkan dependency lane Sep 1, 2026
Copilot AI requested a review from makr-code September 1, 2026 05:51
@makr-code
makr-code marked this pull request as ready for review September 1, 2026 05:52
@makr-code
makr-code merged commit 415a06f into develop Sep 1, 2026
11 of 12 checks passed
@github-actions github-actions Bot added this to the v2.4.1 milestone Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🔴 Chronic Build Failures — Error Report

3 participants