Skip to content

Commit 415a06f

Browse files
authored
Merge pull request #6222 from makr-code/copilot/fix-chronic-build-failures-again
Fix chronic CI build blockers in NVMe zone/completion paths and LLM Vulkan dependency lane
2 parents 4a673e6 + 7310d34 commit 415a06f

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/build-llm-inference.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ jobs:
150150
librocksdb-dev libgtest-dev libssl-dev zlib1g-dev libzstd-dev \
151151
libfmt-dev libspdlog-dev nlohmann-json3-dev libtbb-dev \
152152
libyaml-cpp-dev libcurl4-openssl-dev libcpp-httplib-dev libboost-system-dev \
153-
libboost-filesystem-dev libpugixml-dev
153+
libboost-filesystem-dev libpugixml-dev libvulkan-dev
154154
155155
- name: Prepare optional submodule paths
156156
run: |

src/storage/nvme_manager.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,7 @@ bool NVMeManager::submitWrite(const NVMeIORequest& req) {
472472
}
473473

474474
int NVMeManager::pollCompletions(std::vector<NVMeIOResult>& results,
475-
uint32_t /*min_complete*/) {
475+
uint32_t min_complete) {
476476
results.clear();
477477
#ifdef THEMIS_ENABLE_IO_URING
478478
# ifdef __linux__
@@ -516,7 +516,7 @@ int NVMeManager::pollCompletions(std::vector<NVMeIOResult>& results,
516516
// ZNS zone management
517517
// ─────────────────────────────────────────────────────────────────────────────
518518

519-
bool NVMeManager::resetZone(uint64_t /*zone_offset*/) {
519+
bool NVMeManager::resetZone(uint64_t zone_offset) {
520520
if (!config_.enable_zns || config_.device_path.empty()) {
521521
return false;
522522
}
@@ -545,7 +545,7 @@ bool NVMeManager::resetZone(uint64_t /*zone_offset*/) {
545545
#endif
546546
}
547547

548-
bool NVMeManager::finishZone(uint64_t /*zone_offset*/) {
548+
bool NVMeManager::finishZone(uint64_t zone_offset) {
549549
if (!config_.enable_zns || config_.device_path.empty()) {
550550
return false;
551551
}
@@ -573,7 +573,7 @@ bool NVMeManager::finishZone(uint64_t /*zone_offset*/) {
573573
#endif
574574
}
575575

576-
uint64_t NVMeManager::getZoneWritePointer(uint64_t /*zone_offset*/) const {
576+
uint64_t NVMeManager::getZoneWritePointer(uint64_t zone_offset) const {
577577
if (!config_.enable_zns || config_.device_path.empty()) {
578578
return UINT64_MAX;
579579
}

0 commit comments

Comments
 (0)