Skip to content

override band plugin blocks with magstock-specific info - #65

Merged
binary1230 merged 2 commits into
masterfrom
blockify_band_agreement
May 20, 2016
Merged

override band plugin blocks with magstock-specific info#65
binary1230 merged 2 commits into
masterfrom
blockify_band_agreement

Conversation

@binary1230

@binary1230 binary1230 commented May 17, 2016

Copy link
Copy Markdown
Contributor

Allow magstock to override sections of agreement without needing to paste the entire agreement.html here.

now includes @cybersenshi's updated text (but not [correct] CSS re-styling) from her WIP PR: #64

requires the following to be merged first:

- turn parts of the band agreement into blocks for extending via plugins
- requires venue INI settings PR
@EliAndrewC

Copy link
Copy Markdown
Contributor

I'll need to see how this works out in practice. I like the idea, but at a glance, it doesn't look like this will necessarily reduce the amount of copy/paste and/or overriding that we have to do.

@kitsuta

kitsuta commented May 17, 2016

Copy link
Copy Markdown
Member

I like this. One thing it will get us is the ability to separate/protect the form part of the page, allowing child templates to just override the text parts without having to worry about bugfixes/additions/etc to the form. Many of our templates unfortunately don't benefit from that, being JUST a form, but it's good here.

@binary1230 binary1230 changed the title convert band agreement into blocks (WIP, proof of concept only) convert band agreement into blocks May 17, 2016
@binary1230 binary1230 changed the title convert band agreement into blocks override band plugin blocks with magstock-specific info May 17, 2016
@binary1230

Copy link
Copy Markdown
Contributor Author

hey @EliAndrewC @kitsuta @cybersenshi go ahead and review this, it's ready. I think it ended up being a big win.

As you can see, the magstock block overrides are just about zero HTML elements, zero styling, and are very simple to achieve the desired result. Check out this file to see that it's a lot simpler than the previous approach: https://raw.githubusercontent.com/magfest/magstock/6c685b15675cf4ad300e8f34e601399532d59b4c/magstock/templates/bands/agreement.html

This is also a big win in that the styling work which @cybersenshi is doing now only has to take place in the bands plugin, not in magstock, so we don't have to worry about mirroring two copies of the same styling in bands plugin and in magstock plugin, and we will automatically get those style changes when we bring this into maglabs and prime.

@kitsuta

kitsuta commented May 17, 2016

Copy link
Copy Markdown
Member

Uh... where's agreement-base.html? :)

@kitsuta

kitsuta commented May 17, 2016

Copy link
Copy Markdown
Member

Nevermind, found it. For some reason I didn't get the email about the bands PR. +1

@cybersenshi

Copy link
Copy Markdown
Contributor

+1 Correct text.

@binary1230
binary1230 merged commit 585c615 into master May 20, 2016
@binary1230
binary1230 deleted the blockify_band_agreement branch May 20, 2016 10:53
@EliAndrewC

Copy link
Copy Markdown
Contributor

+1 (belatedly)

I agree that this did make the event-specific code a lot cleaner with less copy/paste than we'd have had otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants