This repository was archived by the owner on Feb 10, 2018. It is now read-only.
convert band agreement page into blocks, for overriding in downstream plugins - #27
Merged
Conversation
- turn parts of the band agreement into blocks for extending via plugins - requires venue INI settings PR
- for overridding by downstream plugins, like magstock
binary1230
changed the title
binary1230
changed the title
Contributor
|
+1, good use of Django templating. Much nicer than a hundred includes. |
Contributor
Author
|
meetig with chaney, TODO: this is the new form stuff, needs to go back to the old form stuff |
| <h3> | ||
| Your Information | ||
| </h3> | ||
| <form method="post" action="agreement" class="form-horizontal" role="form"> |
Contributor
Author
There was a problem hiding this comment.
@cybersenshi notes that this form here is actually the new styling and we need to put back in the old styling for this PR
- revert Chaney's WIP formatting I accidentally pulled in, use original
Contributor
Author
|
OK, this form now has the original styling back in, so should be good to go. Looks good locally. @cybersenshi plz give this a review and when you +1, it's ready to merge. After, merge #28 |
|
+1 |
Contributor
|
+1 (belatedly) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow other plugins (like magstock) to override sections of agreement without needing to paste the entire agreement.html here.
now includes all of @cybersenshi's updated text (but not styling), it appears to work great. if this is what we go for, take the rest of @cybersenshi's stuff from magfest/magstock#64 and put it in here.
an example of a PR that overrides is here: magfest/magstock#65
downstream plugins can also turn off sections by blanking them out, for instance if we didn't want to have a merch section, you can do:
{% block band_text_merch %}{% endblock %}