Skip to content

⚡ Bolt: [performance improvement] remove vector allocations in catch-all path encoding #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madmax983 wants to merge 1 commit into
base: trunk-dev
Choose a base branch
from
Open

⚡ Bolt: [performance improvement] remove vector allocations in catch-all path encoding #1957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions autumn/src/mcp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1826,11 +1826,7 @@ fn build_request(
// Use the same full segment encoder the typed path helpers use, so an
// MCP call accepts the same values a direct HTTP caller could pass.
let encoded = if is_catch_all {
value
.split('/')
.map(crate::paths::encode_path_segment)
.collect::<Vec<_>>()
.join("/")
crate::paths::encode_catch_all_param(&value)
} else {
crate::paths::encode_path_segment(&value)
};
Expand Down
32 changes: 20 additions & 12 deletions autumn/src/paths.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,18 +58,26 @@ pub fn encode_path_segment(value: impl std::fmt::Display) -> String {
#[must_use]
pub fn encode_catch_all_param(value: impl std::fmt::Display) -> String {
let s = value.to_string();
s.split('/')
.map(|segment| {
if segment == "." {
"%2E".to_string()
} else if segment == ".." {
"%2E%2E".to_string()
} else {
percent_encode(segment)
}
})
.collect::<Vec<String>>()
.join("/")
let mut out = String::with_capacity(s.len() + s.len() / 4);
let mut iter = s.split('/').map(|segment| {
if segment == "." {
"%2E".to_string()
} else if segment == ".." {
"%2E%2E".to_string()
} else {
percent_encode(segment)
}
});

if let Some(first) = iter.next() {
out.push_str(&first);
for item in iter {
out.push('/');
out.push_str(&item);
}
}

out
}

/// Percent-encode a query component per RFC 3986.
Expand Down
Loading