⚡ Bolt: [performance improvement] remove vector allocations in catch-all path encoding#1957
⚡ Bolt: [performance improvement] remove vector allocations in catch-all path encoding#1957madmax983 wants to merge 1 commit into
Conversation
Replaces an intermediate `.collect::<Vec<_>>().join("/")` with a
pre-allocated `String` that is populated via an iterator and `.push_str()`.
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
💡 What:
Optimized
encode_catch_all_paraminautumn/src/paths.rsto append path segments directly into a pre-allocatedStringbuffer instead of collecting an intermediateVec<String>and then joining. Additionally, reused this optimized function inautumn/src/mcp.rsforbuild_requestto handle MCP catch-all paths instead of duplicating the.collect::<Vec<_>>().join("/")pattern.🎯 Why:
The
.collect::<Vec<_>>().join("/")pattern requires multiple heap allocations: one for each segment string (during mapping) and one for the intermediateVecholding them, which is immediately discarded after the.join("/")allocates the final string. Removing intermediate collections on string operations is a canonical zero-cost abstraction improvement.📊 Impact:
Reduces heap allocations during the encoding of catch-all parameters. The exact number of allocations saved depends on the number of path segments, but it eliminates the
Vecallocation entirely.🔭 Measurement:
Run
cargo benchif available for routing path encoding, or review the allocations in a memory profiler for MCP routing calls. Runcargo test -p autumn-web --libto ensure no regressions in behavior.PR created automatically by Jules for task 2922191217707296986 started by @madmax983