feat(scope): show the DN/LDAP path field in the creation dialog#57
Merged
Conversation
The container scope creation dialog only exposed the Name field while the edition dialog showed the LDAP Path / DN. Adds the same field to the creation mode so administrators can set the DN at creation time rather than having to edit immediately after. The field is required on create (backend ContainerScope.dn is @NotNull/@notblank) and the save payload now carries the dn for both create and update. Closes #55.
|
|
Collaborator
|
The path is still not editable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaces the LDAP Path/DN field in the container scope creation dialog, mirroring what edition mode already exposes.
Context
On
/id/scope, the "New scope" dialog only exposed the Name field. The DN/LDAP Path — shown (read-only) in edition mode — was missing on create, although the backend requires it (ContainerScope.dnis@NotNull @NotBlank @DistinguishName).Changes
disabled) on edit (unchanged behaviour).save()payload now carriesdnfor both create and update — this also fixes update, which previously sentdn=nulland would fail backend validation.containerScope.dnandcommon.requiredi18n keys; no new keys.Test
Validated at runtime against a live backend: the LDAP Path field shows in the creation dialog, is editable, and is required (blocks empty submit).
Closes #55.