fix(scope): make the DN/LDAP path editable in edition mode#58
Merged
Conversation
Follow-up to #57. The previous patch kept the DN read-only when editing an existing container scope. Per the issue comment 'And this path should be editable', the LDAP path must be editable in both create and edit mode. The backend already allows updating ContainerScope.dn (no @immutable on the field). Closes #55.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #57. The previous patch kept the DN field read-only when editing an existing container scope.
In the issue comment, Fabrice clarified: "And this path should be editable". So the LDAP path must be editable in both create and edit mode, not only at creation.
This change removes the
!!editTarget?.idpart of the field'sdisabledbinding (the field stays disabled only in read-only/view mode) and simplifies the validation rules so the path is always required.The backend already allows updating
ContainerScope.dn(no@Immutableon the field).Closes #55.