Skip to content

fix: swap names of Dyadic.not_lt and Dyadic.not_le #14890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kim-em merged 1 commit into from
Sep 1, 2026
+4 −4
Merged

fix: swap names of Dyadic.not_lt and Dyadic.not_le #14890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Init/Data/Dyadic/Basic.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,12 +697,12 @@ theorem toRat_lt_toRat_iff {x y : Dyadic} : x.toRat < y.toRat ↔ x < y := blt_i
theorem toRat_le_toRat_iff {x y : Dyadic} : x.toRat ≤ y.toRat ↔ x ≤ y := ble_iff_toRat.symm

@[simp]
protected theorem not_le {x y : Dyadic} : ¬x < y ↔ y ≤ x := by
protected theorem not_lt {x y : Dyadic} : ¬x < y ↔ y ≤ x := by
simp only [· ≤ ·, · < ·, Bool.not_eq_true, blt_eq_false_iff]

@[simp]
protected theorem not_lt {x y : Dyadic} : ¬x ≤ y ↔ y < x := by
rw [← Dyadic.not_le, Decidable.not_not]
protected theorem not_le {x y : Dyadic} : ¬x ≤ y ↔ y < x := by
rw [← Dyadic.not_lt, Decidable.not_not]

@[simp]
protected theorem le_refl (x : Dyadic) : x ≤ x := by
Expand All @@ -723,7 +723,7 @@ protected theorem le_total (x y : Dyadic) : x ≤ y ∨ y ≤ x := by
exact Rat.le_total

instance : Std.LawfulOrderLT Dyadic where
lt_iff a b := by rw [← Dyadic.not_lt, iff_and_self]; exact (Dyadic.le_total _ _).resolve_left
lt_iff a b := by rw [← Dyadic.not_le, iff_and_self]; exact (Dyadic.le_total _ _).resolve_left

instance : Std.IsPreorder Dyadic where
le_refl := Dyadic.le_refl
Expand Down
Loading