Skip to content

fix: swap names of Dyadic.not_lt and Dyadic.not_le - #14890

Merged
kim-em merged 1 commit into
leanprover:masterfrom
plp127:aliu/dyadic-not_lt_le
Sep 1, 2026
Merged

fix: swap names of Dyadic.not_lt and Dyadic.not_le#14890
kim-em merged 1 commit into
leanprover:masterfrom
plp127:aliu/dyadic-not_lt_le

Conversation

@plp127

@plp127 plp127 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

This PR swaps the names of Dyadic.not_lt and Dyadic.not_le, so that Dyadic.not_lt reads ¬x < y ↔ y ≤ x and Dyadic.not_le reads ¬x ≤ y ↔ y < x. This is consistent with the corresponding lemmas for Nat, Int, Rat, and with _root_.not_lt and _root_.not_le in mathlib.

@plp127
plp127 requested a review from kim-em as a code owner August 22, 2026 01:45
@github-actions github-actions Bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 22, 2026
@mathlib-lean-pr-testing

Copy link
Copy Markdown

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase f6c7d68c7fc27e3b60585f30740c7d141d3c5b36 --onto 16e77c407779fde9a649adf3478204d1915371a3. You can force Mathlib CI using the force-mathlib-ci label. (2026-08-22 02:08:26)

@leanprover-bot

Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase f6c7d68c7fc27e3b60585f30740c7d141d3c5b36 --onto 16e77c407779fde9a649adf3478204d1915371a3. You can force reference manual CI using the force-manual-ci label. (2026-08-22 02:08:28)

@leanprover-bot leanprover-bot added the P-medium We may work on this issue if we find the time label Aug 25, 2026
@kim-em kim-em added the changelog-library Library label Aug 31, 2026
@kim-em
kim-em enabled auto-merge August 31, 2026 04:53
@kim-em kim-em changed the title fix(Data/Dyadic): swap names of Dyadic.not_lt and Dyadic.not_le fix: swap names of Dyadic.not_lt and Dyadic.not_le Sep 1, 2026
@kim-em
kim-em added this pull request to the merge queue Sep 1, 2026
Merged via the queue into leanprover:master with commit 5527550 Sep 1, 2026
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-library Library P-medium We may work on this issue if we find the time toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants