Skip to content

fix: fix security issue in webhook.js #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix security issue in webhook.js #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions server/src/routes/webhook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ const storage = require('../storage');

const router = express.Router();

// Maximum age of a webhook event before it is rejected as a potential replay.
const WEBHOOK_EVENT_MAX_AGE_SECONDS = 300;

async function getCustomerEmail(customerId) {
const customer = await stripe.customers.retrieve(customerId);
return customer.email ? customer.email.toLowerCase() : null;
Expand All @@ -33,6 +36,14 @@ router.post('/stripe', async (req, res) => {
return res.status(400).json({ error: 'Invalid signature' });
}

// Reject stale events to mitigate replay attacks (an intercepted, validly
// signed event replayed later than when Stripe originally sent it).
const eventAgeSeconds = Math.floor(Date.now() / 1000) - event.created;
if (eventAgeSeconds > WEBHOOK_EVENT_MAX_AGE_SECONDS) {
console.error(`[webhook] Rejected stale event ${event.id} (age: ${eventAgeSeconds}s)`);
return res.status(400).json({ error: 'Event too old' });
}

// Reject events whose product isn't in our allowlist. Protects against
// cross-product bleed when multiple apps share a Stripe account.
try {
Expand Down