fix: fix security issue in webhook.js - #229
Open
anupamme wants to merge 1 commit into
Open
Conversation
Automated security fix generated by OrbisAI Security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
server/src/routes/webhook.js.Vulnerability
V-001server/src/routes/webhook.js:20Description: The Stripe webhook handler correctly verifies webhook signatures using Stripe's constructWebhookEvent function, which validates that requests originate from Stripe using the STRIPE_WEBHOOK_SECRET. However, the implementation lacks event timestamp validation, which could allow replay attacks if an attacker intercepts a valid webhook event and re-sends it within the signature validity window.
Evidence
Exploitation scenario: An attacker with network access between Stripe and the server (e.g., compromised network infrastructure) could capture a valid webhook event and replay it.
Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Threat Model Context
This route handler appears to be publicly accessible.
Changes
server/src/routes/webhook.jsBehavior Preservation
The change is scoped to 1 file on the vulnerable path.
Automated security fix by OrbisAI Security