Repository navigation
Remove client code for APIs the product never calls - #6
Merged
Merged
Conversation
The README already said HeatShield deliberately does not call SIM/Device Swap, the KYC family or Number Verification, yet the client still carried them as portfolio-era leftovers. Removed: - NacClient: 17 methods (number recycling, call forwarding x2, KYC tenure, age and match, number verification, SIM swap x2, device swap x2, consent, roaming, reachability and roaming subscriptions) and their path-table entries, plus the unused congestion_subs path. - FixtureBackend: the matching responses, their helpers and 15 profile fields no remaining API reads. - Simulator: the matching routes and the passthrough bearer check. - tests: the three tests of removed APIs. The simulator round-trip test now exercises the six product APIs over HTTP. Test numbers moved from real Turkish mobile format to the non-assignable +99999 range the README promises. tools/verify_live.py now probes exactly the six APIs: - The broken portfolio table patcher is gone; it looked for heatshield/ inside heatshield/ and for a master table not in the repo. - So is the OAuth fetch, since no Bearer path remains. - It loads .env through tools/_common and defaults to the documented +99999000001000 sandbox number. - tests/test_verify_live.py runs its probes, cleanup and report offline against the fixture backend. It never calls main(), so it never reads .env and makes no network calls. evidence/ is untouched. The 9 Sep 2026 probe can be re-run exactly from tag v0.1-hackathon. The full six-scenario demo JSON is byte-identical; 197 tests pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…list" - README and docs/api-availability.md explain that the 9 Sep 2026 probe ran with verify_live.py at tag v0.1-hackathon, which also probed APIs since removed, so those results in evidence/ are historical and reproducible from the tag. - README keeps "Top 10 finalist" and drops "Results pending". - docs/api-availability.md: the QoD path is v1, as in the code and the probe, not v0. - DEVELOPER-GUIDE: the qod_create example now matches the real signature. - .env.example: the OAuth block is removed, since nothing reads those variables now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5. Merge order: #1 → #2 → #3 → #4 → #5 → this.
The README already said HeatShield deliberately does not call SIM/Device Swap, the KYC family or Number Verification. This PR makes the code say the same thing.
Removed
NacClient: 17 methods and their path-table entries (number recycling, call forwarding, KYC tenure, age and match, number verification, SIM swap, device swap, consent, roaming, reachability and roaming subscriptions), plus the unusedcongestion_subspath.tools/verify_live.py:heatshield/heatshield/and a master table not in the repo.+99999000001000.Kept on purpose
evidence/is untouched. The 9 Sep 2026 probe can be re-run exactly from tagv0.1-hackathon. The README anddocs/api-availability.mdnow say so, and call the removed APIs' results in the evidence file historical._ortak/_template/nac_client) lives outside this repository and is not touched.Also fixed
+99999…range, as the README promises.docs/api-availability.md: the QoD path isv1, notv0.qod_createexample in DEVELOPER-GUIDE now matches the real signature..env.exampledrops the OAuth block, since nothing reads it now.Verification
tests/test_verify_live.pyruns the probe logic offline against fixtures. It never callsmain(), so it never reads.env.After merge to main (Render auto-deploys)
On heatshield-demo.onrender.com/demo, check Hot day, Collapse, No breach and Planner guard.
🤖 Generated with Claude Code