Repository navigation
Preserve projected radius in direct flux coordinates - #2
Closed
krystophny wants to merge 1 commit into
Closed
krystophny wants to merge 1 commit into
krystophny wants to merge 1 commit into
Conversation
krystophny
added a commit
to itpplasma/GPEC
that referenced
this pull request
Oct 23, 2026
Fork-PR: krystophny#2 Cherry-picked-from: 188e181
This was referenced Oct 23, 2026
Owner
Author
|
The complete projected-radius correction is integrated into the canonical GPEC production fork through PR6, squash 91808b3. It also projects the current upstream common-angle samples and passes the existing delivered-chart oracle at its unchanged tolerance. The maintained upstream report355 and this original source branch remain retained. Chris&AI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
direct_fl_intprojects each field-line point back onto its target flux surface, but previously stored the uncorrected ODE radius iny_out. The resultingrzphichart disagreed with the corrected coordinates used for field evaluation. Store the projected radius in the chart while preserving the ODE state and integration tolerances.Validation:
read_eq_efitand checks the delivered chart against the input flux function. Its maximum normalized flux residual is 2.45438e-5 before the fix and 2.90926e-6 after it (threshold 1e-5).git diff --checkpasses.Chris&AI