Repository navigation
BUG FIX - Keep delivered direct-chart radii on their input flux surfaces - #355
krystophny wants to merge 1 commit into
Conversation
…nates (cherry picked from commit ff6edda)
|
Thanks Chris. I went through this carefully, since
The Julia code already has this on its list — OpenFUSIONToolkit/GPEC#544 item 3 — and I've left a pointer there. If anyone wants to pursue it in Fortran after 1.6, the evidence needed is an A/B at default etol and at mpsi ≥ 256 on |
Keep radii delivered to the direct flux-coordinate chart on the requested input flux surface. The common-angle sampling path introduced upstream bypassed the earlier corrected integration-output radius.
This layer preserves both projected integration-output radii and projected common-angle samples through existing direct_refine. It changes no LSODE state, tolerances or profile-integral policy. The native regression checks the delivered geometry against the public analytic equilibrium. Retains and completes accepted personal GPEC PR2.
Native qualification used the complete production union: focused checks passed in3361934 (2/2 in8.253s), followed by full native Make with the owning GNU debug flags. Continuation3361977 completed fresh ideal/kinetic and the remaining resistive/reconstruction stages under53 pinned runtime libraries. Reconstruction relative error0.006969 is below the unchanged0.02 tolerance and curl passed. Independent source/binary/compiler/runtime pre/post checks passed. The original3361934 wrapper status remains failed because RMATCH deliberately emits RPEC termination and closes globalsol.bin; this native product contract was verified rather than relabelled generic normal termination. Exact union tree equals qualified543b87f0; no private inputs or weakened gates.
The old integration-output radius fix alone fails the current common-angle delivered-chart oracle at2.469907589438378e−5 against the existing1e−5 tolerance. Projecting the actual delivered samples through the existing native refinement routine makes that same oracle pass. No solver tolerance is changed.
This draft targets the external Fortran GPEC upstream develop branch. Qualification receipts above refer to the complete maintained-fork union, which also includes independent message/output-state fixes, rather than claiming an independent full-stage run of this upstream-only branch. Public analytic input only; no private campaign fixture. Chris retains upstream review and promotion.
Chris&AI