Repository navigation
Preserve the field-line integration failure diagnostic - #1
Closed
krystophny wants to merge 2 commits into
Closed
krystophny wants to merge 2 commits into
krystophny wants to merge 2 commits into
Conversation
krystophny
added a commit
to itpplasma/GPEC
that referenced
this pull request
Oct 23, 2026
Fork-PR: krystophny#1 Cherry-picked-from: 3df0b5c, bb3f02a
This was referenced Oct 23, 2026
Owner
Author
|
Integrated into the canonical GPEC production fork through PR5, squash 30985f0. The maintained upstream defect report354 and this original source branch remain retained. Closing this duplicate delivery path. Chris&AI |
logan-nc
pushed a commit
to PrincetonUniversity/GPEC
that referenced
this pull request
Oct 24, 2026
Fork-PR: krystophny#1 Cherry-picked-from: 3df0b5c, bb3f02a (cherry picked from commit c1d9fa6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The field-line integration failure path formats a 65-character message into a 64-character buffer. It raises a Fortran
End of recorderror beforeprogram_stopcan report the integration failure.Increase the buffer to 128 characters and use unrestricted integer widths, so five-digit step limits are printed as numbers rather than asterisks. The regression compiles and executes the actual declaration, FORMAT and WRITE from
direct_fl_int, with a deterministic 10000-step diagnostic: the parent fails withEnd of record; this change prints the complete step, angle and surface index.Validation:
python regression/test/test_direct_error_message.pypasses with gfortran. This fixes the diagnostic, not the underlying numerical integration failure observed for a coarse exported equilibrium.Chris&AI