Repository navigation
GPEC - BUGFIX - Preserve field-line failure diagnostics - #5
Merged
Merged
Conversation
krystophny
marked this pull request as ready for review
October 23, 2026 21:54
Fork-PR: krystophny#1 Cherry-picked-from: 3df0b5c, bb3f02a
krystophny
force-pushed
the
fix/fieldline-diagnostic-production-20261023
branch
from
October 23, 2026 22:01
c1d9fa6 to
5baa6cf
Compare
krystophny
changed the base branch from
sync/production-upstream-20261023
to
develop
October 23, 2026 22:02
krystophny
enabled auto-merge
October 23, 2026 22:02
auto-merge was automatically disabled
October 23, 2026 22:04
Pull request was closed
krystophny
enabled auto-merge
October 23, 2026 22:04
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the field-line integration failure diagnostic when a step count exceeds its old fixed-width field. The existing64-character internal buffer could itself overflow while reporting a solver failure.
This layer changes only the message capacity/format and adds a native formatter regression. Retains the accepted personal GPEC PR1 repair.
Native qualification used the complete production union: focused checks passed in3361934 (2/2 in8.253s), followed by full native Make with the owning GNU debug flags. Continuation3361977 completed fresh ideal/kinetic and the remaining resistive/reconstruction stages under53 pinned runtime libraries. Reconstruction relative error0.006969 is below the unchanged0.02 tolerance and curl passed. Independent source/binary/compiler/runtime pre/post checks passed. The original3361934 wrapper status remains failed because RMATCH deliberately emits RPEC termination and closes globalsol.bin; this native product contract was verified rather than relabelled generic normal termination. Exact union tree equals qualified543b87f0; no private inputs or weakened gates.
Stacked owned GPEC production fork layer, one squash commit per logical change. Exact merge-group GNU/Intel/hygiene checks remain mandatory. Gremlin is unsupported for this legacy Make backend.
Chris&AI