Fix Brazil fetcher, fixes #11 - #48
Merged
Merged
Conversation
Closed
This was referenced Oct 17, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To not mess up with our git history and because I messed up a git merge, I created this new branch to fix #11.
The fetcher still needs to be extended to instantaneous features, but that will happen in a next PR. For now, this is just fixing the daily stuff and adding a metadata function. Note that the new cached metadata file includes all (37k) stations in Brazil, out of which the vast majority are not river related measurement stations (check column
Tipo_Estacao_Qual_Agua). But maybe it is worth to just cache those rows?