Skip to content

fix: reset keyboard values when disabled - #1546

Open
MarshallBear1 wants to merge 1 commit into
kirillzyusko:mainfrom
MarshallBear1:codex/reset-keyboard-values-when-disabled
Open

fix: reset keyboard values when disabled#1546
MarshallBear1 wants to merge 1 commit into
kirillzyusko:mainfrom
MarshallBear1:codex/reset-keyboard-values-when-disabled

Conversation

@MarshallBear1

Copy link
Copy Markdown

📜 Description

Reset Animated and Reanimated keyboard values, plus the cached focused-input layout, when the controller is disabled mid-transition.

Fixes #1416.

📢 Changelog

JS

  • clear stale keyboard animation state when disabled
  • add a regression test for disabling mid-transition

🤔 How Has This Been Tested?

  • focused Jest regression suite
  • TypeScript and ESLint
  • disabled during keyboard focus, re-enabled, and reopened the keyboard on iPhone 17 / iOS 26.5 Simulator

📝 Checklist

  • CI successfully passed
  • Added regression tests

@github-actions

Copy link
Copy Markdown
Contributor

📊 Package size report

Current size Target Size Difference
333568 bytes 333118 bytes 450 bytes 📈

Comment thread src/animated.tsx
Comment on lines +103 to +104
progress.setValue(0);
height.setValue(0);

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does setValue really works if the value is driven by native driver?..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useReanimatedKeyboardAnimation animated values are not reset after KeyboardController enable/disable

2 participants