fix: stabilize keyboard layout tracking - #1539
Closed
MarshallBear1 wants to merge 3 commits into
Closed
Conversation
Contributor
📊 Package size report
|
Owner
|
Hey @MarshallBear1 Could you split your PR into 4 smaller PRs? For me it looks like you are fixing 4 different problems in a single PR, I'll not be able to merge it. Correct fix for AI comments already landed here: #1542 |
Author
|
Split as requested:
The duplicate AI-review workflow change was dropped because #1542 already landed. Thanks for the direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeyboardAvoidingViewpadding modes from feeding their animated layout back into the keyboard-height calculationKeyboardControlleris disabled mid-transitionValidation
yarn jest src/__tests__/animated.spec.tsx src/components/KeyboardAvoidingView/__tests__/initialFrame.spec.tsx --runInBandyarn typescriptyarn lintKeyboardAvoidingViewkeyboard open/dismiss flow