-
Notifications
You must be signed in to change notification settings - Fork 0
Update telegram_login package to version 1.2.1 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,9 +10,8 @@ import UIKit | |
| /// - Receiving and processing callback URLs from Telegram | ||
| /// - Delivering login results or errors back to Dart | ||
| /// | ||
| /// The plugin supports both classic `UIApplicationDelegate` apps and modern | ||
| /// scene-based apps (iOS 13+). URL callbacks are automatically forwarded to | ||
| /// the Telegram SDK for processing. | ||
| /// URL callbacks from the app delegate are automatically forwarded to the | ||
| /// Telegram SDK for processing. | ||
| public class TelegramLoginPlugin: NSObject, FlutterPlugin { | ||
|
|
||
| /// Indicates whether the Telegram Login SDK has been configured with | ||
|
|
@@ -27,7 +26,7 @@ public class TelegramLoginPlugin: NSObject, FlutterPlugin { | |
| /// Registers the plugin with the Flutter engine. | ||
| /// | ||
| /// Creates the method channel, initializes the plugin instance, and | ||
| /// registers for application/scene delegate callbacks to handle URL opens. | ||
| /// registers for application delegate callbacks to handle URL opens. | ||
| /// | ||
| /// - Parameter registrar: The Flutter plugin registrar for registering | ||
| /// method channels and application delegates. | ||
|
|
@@ -39,9 +38,6 @@ public class TelegramLoginPlugin: NSObject, FlutterPlugin { | |
| let instance = TelegramLoginPlugin() | ||
| registrar.addMethodCallDelegate(instance, channel: channel) | ||
| registrar.addApplicationDelegate(instance) | ||
| if #available(iOS 13.0, *) { | ||
| registrar.addSceneDelegate(instance) | ||
| } | ||
| } | ||
|
Comment on lines
38
to
41
|
||
|
|
||
| /// Handles incoming method calls from the Dart side. | ||
|
|
@@ -326,52 +322,3 @@ public class TelegramLoginPlugin: NSObject, FlutterPlugin { | |
| return true | ||
| } | ||
| } | ||
|
|
||
| // MARK: - FlutterSceneLifeCycleDelegate (scene-based apps, iOS 13+) | ||
| // | ||
| // These methods are called by Flutter for apps using the UIScene lifecycle | ||
| // (iOS 13+). They handle URL callbacks in modern scene-based apps. | ||
|
|
||
| @available(iOS 13.0, *) | ||
| extension TelegramLoginPlugin: FlutterSceneLifeCycleDelegate { | ||
|
|
||
| /// Handles URL open requests in a scene-based app. | ||
| /// | ||
| /// Called when the app receives a URL through a custom scheme | ||
| /// (e.g., `tglogin://callback`). Extracts the first URL from the | ||
| /// context set and forwards it to the Telegram SDK. | ||
| /// | ||
| /// - Parameters: | ||
| /// - scene: The UIScene that received the URL | ||
| /// - URLContexts: A set of UIOpenURLContext objects containing URLs | ||
| /// - Returns: `true` if a URL was handled, `false` otherwise | ||
| public func scene(_ scene: UIScene, openURLContexts URLContexts: Set<UIOpenURLContext>) -> Bool { | ||
| guard let url = URLContexts.first?.url else { return false } | ||
| DispatchQueue.main.async { [weak self] in | ||
| self?.forwardUrl(url) | ||
| } | ||
| return true | ||
| } | ||
|
|
||
| /// Handles universal link continuations in a scene-based app. | ||
| /// | ||
| /// Called when the app is opened via a universal link during a scene | ||
| /// transition. Checks if the activity is a web browsing activity and | ||
| /// forwards the URL to the Telegram SDK for OAuth callback processing. | ||
| /// | ||
| /// - Parameters: | ||
| /// - scene: The UIScene that received the activity | ||
| /// - userActivity: The NSUserActivity containing the web URL | ||
| /// - Returns: `true` if the URL was handled (was a web browsing URL), | ||
| /// `false` otherwise | ||
| public func scene(_ scene: UIScene, continue userActivity: NSUserActivity) -> Bool { | ||
| guard userActivity.activityType == NSUserActivityTypeBrowsingWeb, | ||
| let url = userActivity.webpageURL else { | ||
| return false | ||
| } | ||
| DispatchQueue.main.async { [weak self] in | ||
| self?.forwardUrl(url) | ||
| } | ||
| return true | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 1.2.1 changelog entry claims this release fixes compilation for “older Flutter SDK versions” (and references APIs missing below Flutter 3.16), but the package’s current SDK constraints require Dart ^3.6.0 (pubspec.yaml), which effectively excludes those older Flutter versions. Consider either (a) adjusting the Dart/Flutter constraints to actually support the targeted older Flutter range, or (b) rewording the changelog to clarify the affected consumer scenario (e.g., users building from source / dependency overrides) so it’s not misleading.