Update telegram_login package to version 1.2.1 - #9
Conversation
…ation issues for older Flutter SDK versions by removing unsupported APIs. Adjust documentation and dependencies accordingly.
There was a problem hiding this comment.
Pull request overview
This PR releases telegram_login v1.2.1 by bumping version references and adjusting the iOS plugin registration to avoid using scene-delegate APIs that are unavailable on some Flutter SDK versions.
Changes:
- Bump package/podspec/README dependency versions to
1.2.1. - Remove iOS
addSceneDelegateregistration andFlutterSceneLifeCycleDelegateconformance fromTelegramLoginPlugin. - Add a
1.2.1changelog entry describing the iOS compatibility fix.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
telegram_login/pubspec.yaml |
Bumps Dart package version to 1.2.1. |
telegram_login/ios/telegram_login.podspec |
Bumps iOS pod version to 1.2.1. |
telegram_login/ios/Classes/TelegramLoginPlugin.swift |
Removes scene delegate registration/conformance; relies on application delegate forwarding only. |
telegram_login/README.md |
Updates dependency snippet to ^1.2.1. |
telegram_login/CHANGELOG.md |
Adds 1.2.1 release notes describing the iOS compilation fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - Fix iOS compilation error for consumers on older Flutter SDK versions | ||
| - Removed `FlutterSceneLifeCycleDelegate` conformance and `addSceneDelegate` call | ||
| - These APIs are not available on Flutter versions below 3.16+ | ||
| - `addApplicationDelegate` alone is sufficient; Flutter's engine forwards scene delegate URL events to registered application delegates automatically |
There was a problem hiding this comment.
The 1.2.1 changelog entry claims this release fixes compilation for “older Flutter SDK versions” (and references APIs missing below Flutter 3.16), but the package’s current SDK constraints require Dart ^3.6.0 (pubspec.yaml), which effectively excludes those older Flutter versions. Consider either (a) adjusting the Dart/Flutter constraints to actually support the targeted older Flutter range, or (b) rewording the changelog to clarify the affected consumer scenario (e.g., users building from source / dependency overrides) so it’s not misleading.
| - Fix iOS compilation error for consumers on older Flutter SDK versions | |
| - Removed `FlutterSceneLifeCycleDelegate` conformance and `addSceneDelegate` call | |
| - These APIs are not available on Flutter versions below 3.16+ | |
| - `addApplicationDelegate` alone is sufficient; Flutter's engine forwards scene delegate URL events to registered application delegates automatically | |
| - Fix iOS compilation issues in source/override-based builds that use Flutter versions below 3.16 | |
| - Removed `FlutterSceneLifeCycleDelegate` conformance and `addSceneDelegate` call | |
| - These APIs are not available in Flutter versions below 3.16 | |
| - `addApplicationDelegate` alone is sufficient because Flutter's engine forwards scene delegate URL events to registered application delegates automatically | |
| - This change does not alter the package's published Dart/Flutter SDK constraints |
| let instance = TelegramLoginPlugin() | ||
| registrar.addMethodCallDelegate(instance, channel: channel) | ||
| registrar.addApplicationDelegate(instance) | ||
| if #available(iOS 13.0, *) { | ||
| registrar.addSceneDelegate(instance) | ||
| } | ||
| } |
There was a problem hiding this comment.
The PR metadata/title suggests this is primarily a version bump, but the diff also changes iOS runtime/registration behavior by removing addSceneDelegate / FlutterSceneLifeCycleDelegate handling. Please update the PR description and select the appropriate “Type of Change” checkbox(es) so reviewers/consumers can understand the behavioral impact of the release.
Description
Type of Change