Split the propagation-time correction into independent hit-time and time-window flags - #65
Open
jburzy wants to merge 2 commits into
Open
Split the propagation-time correction into independent hit-time and time-window flags#65jburzy wants to merge 2 commits into
jburzy wants to merge 2 commits into
Conversation
…me window cut Split the time window cut's propagation time-of-flight correction out of CorrectTimesForPropagation into a new independent flag: - CorrectTimesForPropagation (default false, unchanged): subtract the propagation time-of-flight (radial distance/c) from the stored hit time - CorrectTimeWindowForPropagation (new, default true): subtract the propagation time-of-flight from the hit time when applying the time window cut This allows applying the time window cut on TOF-corrected times without altering the stored hit times. Configurations that set CorrectTimesForPropagation=True behave exactly as before without changes.
tmadlener
reviewed
Sep 3, 2026
tmadlener
left a comment
tmadlener
left a comment
Member
There was a problem hiding this comment.
It took me a bit to understand the logic, but I think it's sound and correctly implemented.
| "Correct the stored hit time for the propagation time-of-flight: radial distance/c (default: false)"}; | ||
| Gaudi::Property<bool> m_correctTimeWindowForPropagation{ | ||
| this, "CorrectTimeWindowForPropagation", true, | ||
| "Correct the hit time for the propagation time-of-flight when applying the time window cut (default: true)"}; |
Member
There was a problem hiding this comment.
I think this should also state that this does not affect the stored time.
| double windowT = hitT; | ||
| if (m_correctTimeWindowForPropagation) { | ||
| windowT -= oldPos.r() / (TMath::C() / 1e6); | ||
| } |
Member
There was a problem hiding this comment.
A debug (or maybe better verbose) log output here could help in figuring out why hits are dropped via inspecting the logs.
Member
|
Related (or previous attempt): #57 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DDPlanarDigihad a singleCorrectTimesForPropagationflag that subtracted thepropagation time-of-flight (radial distance/c) from the hit time before the time
window cut. This coupled two independent choices: whether the time window is defined
relative to the expected arrival time, and whether the stored hit times are
TOF-corrected. In particular, it was impossible to apply the usual TOF-corrected time
window while keeping absolute hit times in the output — which is needed when the
downstream tracking wants to use the physical hit time (e.g. time-aware seeding and
4D track finding).
This PR changes the old behavior of
CorrectTimesForPropagationand adds an additional flag:CorrectTimesForPropagation— subtract the propagation TOF from thestored (digitized) hit time
CorrectTimeWindowForPropagation— subtract the propagation TOF from the hittime only when applying the time window cut, leaving the stored time untouched
Setting both reproduces the old
CorrectTimesForPropagation=Truebehaviour.Copied from MuonColliderSoft fork: MuonColliderSoft#17
@madbaron
BEGINRELEASENOTES
CorrectTimeWindowForPropagationproperty (default:true) toDDPlanarDigi, which applies the propagation time-of-flight correction to thehit time only when evaluating the time window cut.
CorrectTimesForPropagation(default:
false, unchanged) now only corrects the stored hit times. Thisallows cutting on TOF-corrected times while keeping absolute hit times in the
output, as needed for time-aware (4D) tracking. Configurations that set
CorrectTimesForPropagation=Truebehave exactly as before; configurationsthat used a time window without it now cut on TOF-corrected instead of raw
times.
ENDRELEASENOTES