F3b-complete — bundle the real NKJV verse-count table - #11
Merged
Conversation
Completes PR #10's human-in-the-loop checklist: generate and commit the real canon-structural verse-count table the SpanResolver consumes. Generated with tools/generate_verse_counts against Concord on the LAN (--translation NKJV --concord-version v1.2.0). meta.book_count=66; 66 book keys matching BookMap; GEN=[31,25,24,...]; PSA 150 chapters; REV 22; no contiguity warnings (NKJV versification is contiguous); all counts positive. VerseCountsSchemaTest flips skipped -> passed against the real asset; full unit suite green (1128 tests, 0 skipped). CLAUDE.md: add the NKJV/private-deployment provenance caveat to the F3b regen note, and a methodology line — PRs at a human-step stop point open as GitHub drafts (mechanically unmergeable until Kris marks ready). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F3b-complete — generate & commit the real verse-count table
Completes the human-in-the-loop checklist from PR #10 (merged at its stop point before the table landed). The bundled asset
app/src/main/assets/anchor/verse_counts.jsonwas confirmed absent onmain; this PR adds it soSpanResolverhas real data andVerseCountsSchemaTestruns.This PR opens READY (not draft) — it is complete by construction (no further human step). It also adds the new methodology rule that human-step PRs open as drafts going forward.
Generated
Run on Kris's LAN box against Concord (a dev-time dependency only — the app never calls Concord at runtime):
Connectivity smoke-test first:
GET /v1/translations→ HTTP 200,NKJVpresent.Emitted
meta:{ "book_count": 66, "concord_version": "v1.2.0", "generated_at": "2026-06-10T00:55:07Z", "source_translation": "NKJV" }Contiguity warnings: none — NKJV's versification is contiguous (it retains the traditional verses), so
len(verses) == max(verse)for every chapter.Sanity (reported)
meta.book_count == 66; 66 book keys, all matchingBookMap.books.GEN=[31, 25, 24, 26, 32, 22, ...](50 chapters).books.PSA= 150 entries (Ps 23 = 6).books.REV= 22 entries.Provenance caveat
The table is generated from NKJV, a licensed translation living in Concord's
data/private/. Bare verse counts are canonical structure (not text), so NKJV is a fine source — but regeneration requires Kris's private Concord deployment. Recorded in CLAUDE.md.Tests — skipped → passed
VerseCountsSchemaTest: previouslyAssume-skipped; now passes against the real asset (asserts 66 keys == BookMap, every count a positive int, fourmetafields,book_count==66, productionVerseTableparses it).:app:assemblePaddleDebug+:app:testPaddleDebugUnitTest— green. Full suite 1128 tests, 0 failures, 0 errors, 0 skipped (was 1 skipped).Scope
2 files changed:
app/src/main/assets/anchor/verse_counts.json(+1331) andCLAUDE.md(+4/−1). No frozen-core,res/, or UI changes.🤖 Generated with Claude Code