Skip to content

add linux-aarch64 GitHub Action coverage - #74

Open
peterbecich wants to merge 1 commit into
jwlawson:masterfrom
peterbecich:arm64-test-coverage
Open

add linux-aarch64 GitHub Action coverage#74
peterbecich wants to merge 1 commit into
jwlawson:masterfrom
peterbecich:arm64-test-coverage

Conversation

@peterbecich

Copy link
Copy Markdown

@jwlawson

jwlawson commented Apr 1, 2025

Copy link
Copy Markdown
Owner

Oh cool, I didn't know about those images. Seems that we pick the wrong binary for arm though

/opt/hostedtoolcache/cmake/3.31.5/arm64/cmake-3.31.5-linux-x86_64/bin/cmake

probably needs adding to

function extractArchFrom(filename: string): string {
if (filename.match(/x86_64/)) {
return 'x86_64';
} else if (filename.match(/x64/)) {
return 'x86_64';
} else if (filename.match(/universal/)) {
return 'x86_64';
} else if (filename.match(/x86/)) {
return 'x86';
} else if (filename.match(/i386/)) {
return 'x86';
} else {
return '';
}
and to here
const arch_candidates = use_32bits ? ['x86'] : ['x86_64', 'x86'];

@henryiii

Copy link
Copy Markdown
Contributor

FWIW, there's windows-11-arm too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants