Linux aarch64 - #78
Conversation
| expect(macosAsset).toEqual({ | ||
| name: 'cmake-3.19.3-Linux-aarch64.tar.gz', | ||
| platform: 'linux', | ||
| arch: '', | ||
| arch: 'arm64', |
There was a problem hiding this comment.
This macos switch is indicative of the "macos == non-x86" issue. I don't really know how to work around it
| arch-series: | ||
| description: 'Architecture series - could be x86, x86_64, arm, arm64 - defaults to arch of runner' | ||
| default: '${{ runner.arch }}' |
There was a problem hiding this comment.
This is only here to force runner.arch to be available - if you know how to query it from ts please let me know and I'll rework it
|
Very nice, i had a look and it looks good to me :) |
|
Well I tested on a workflow and got this issue Maybe this specific version isn't available? https://github.com/Quentium-Forks/nvtop/actions/runs/17033572992/job/48280987223 |
|
For an answer to my previous comment, ARM builds of CMake are only available since 3.19.3, so use this version. |
|
Any update on this? |
|
I'm sorry I didn't see this PR. The recent changes by @tomjakubowski have been merged that should provide support for arm on linux, and available in v2.1 |
|
The PR merged does check the architecture automatically, maybe this should be documented in the README. Also We should warn users that arm64 is only available since CMake version 3.19.3 and windows arm is only available since CMake version 3.24.0 :) |
This is an extension of the comments in #74
In its current form it is incomplete, though enough to get my arm64 linux pipeline working, though it breaks MacOS. I'm raising this in the broken state to get help with how to resolve the issues. They are:
${{ runner.arch }}programmatically - so I hacked it in with aninputusing a default.${{ runner.os }}- or with a general rework.