Skip to content

perf: use crypto.hash when available #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pimterry wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: use crypto.hash when available #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 28 additions & 5 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,33 @@ var Stats = require('fs').Stats

var toString = Object.prototype.toString

// Max size for crypto.hash - beyond this benefits drop to zero or below
var ONESHOT_MAX_LENGTH = 100 * 1024

/**
* Compute the base64 SHA1 hash of an entity.
*
* `crypto.hash` is a faster one-shot API, available since Node.js 20.12.0.
*
* @param {Buffer|string} entity
* @return {string}
* @private
*/

var sha1base64 = typeof crypto.hash === 'function'
? oneshothash
: streaminghash

function oneshothash (entity) {
return entity.length <= ONESHOT_MAX_LENGTH
? crypto.hash('sha1', entity, 'base64')
: streaminghash(entity)
}

function streaminghash (entity) {
return crypto.createHash('sha1').update(entity, 'utf8').digest('base64')
}

/**
* Generate an entity tag.
*
Expand All @@ -43,11 +70,7 @@ function entitytag (entity) {
}

// compute hash of entity
var hash = crypto
.createHash('sha1')
.update(entity, 'utf8')
.digest('base64')
.substring(0, 27)
var hash = sha1base64(entity).substring(0, 27)

// compute length of entity
var len = typeof entity === 'string'
Expand Down