Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypto.hashis very significantly faster than thecreateHash+update+digestdance for small content, and it's now available in all supported Node versions. This PR optimistically uses it when available (20.12.0+) if the body is relatively small (<100KB).Direct benchmark for the two APIs below, on my machine this makes hashing in etag up to 3.2x faster for small strings, and 2.4x faster for small buffers.
Benchmark:
Results on my machine with latest Node below. Significantly faster up to 10KB, then roughly equal. I tested a bit further (slowly) and it drops off, and docs say >5MB is likely slower. I've put the limit at 100KB here.