Skip to content

Fix three confirmed Farsi translation issues#612

Open
Blackspirits wants to merge 5 commits into
jrsoftware:mainfrom
Blackspirits:patch-4
Open

Fix three confirmed Farsi translation issues#612
Blackspirits wants to merge 5 commits into
jrsoftware:mainfrom
Blackspirits:patch-4

Conversation

@Blackspirits

@Blackspirits Blackspirits commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

This pull request now contains only three focused changes confirmed by the native Farsi translation maintainer:

  • changes LanguageName from Farsi to فارسی, matching the naming style used by other translations;
  • restores the omitted Setup reference in SetupAppRunningError;
  • restores the missing %1 placeholder in ErrorFileSize.

All disputed stylistic changes, including the systematic half-space changes and other wording changes, have been reverted. The translation remains under Files/Languages/Unofficial as intended by its maintainer.

Validation:

  • only Files/Languages/Unofficial/Farsi.isl is changed;
  • the final pull request diff contains 3 additions and 3 deletions;
  • UTF-8 without BOM and CRLF line endings are preserved.

@Blackspirits Blackspirits changed the title Fix missing placeholder in Farsi translation Update and review Farsi translation for Inno Setup 6.5.0+ Jul 11, 2026
@Blackspirits

Copy link
Copy Markdown
Contributor Author

I have also contacted Peyman Mohammadi, the original translator listed in the file, by email and asked him to review the proposed changes.

I will update this PR if I receive any corrections or confirmation from him.

@peymanr34

Copy link
Copy Markdown

This is the response I sent to your email @Blackspirits:

Hi BlackSpirits,

Thank you for contacting me, I'll review your PR later today.

By the way, the Farsi (Persian) translation project has a dedicated repository on my own GitHub account:

https://github.com/peymanr34/inno-setup-translations

I was waiting for the next release to include the repository link since I didn't want to submit unnecessary changes.

Another note is that this translation is unofficial by design, because:

As an official translator you will be required to quickly update translations once a change is announced to the istrans mailing list, otherwise your translation might lose official status without notice.

Since I might not make these deadlines, this translation will remain unofficial as long as I'm the maintainer.

Best wishes,
Peyman Mohammadi

@peymanr34 peymanr34 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for:

  • Changing the LanguageName to match the other translations.
  • Catching the missing %1 on line 225
  • Catching the missing "setup" translation on line 74.
  • And other improvements.

But a lot of the proposed changes are opinionated, especially the excessive use of the half-spaces. The half-spaces are technically correct however I deliberately didn't used them because on non-native fonts like "Segue UI" and previously "Tahoma", they arguably make the messages harder to read.

If @martijnlaan aggress with me, please submit the requested changes to my repo. If not I'll go ahead and make the changes on your behalf (with proper attributions of course).

Comment thread Files/Languages/Unofficial/Farsi.isl
Comment thread Files/Languages/Unofficial/Farsi.isl Outdated
Comment thread Files/Languages/Unofficial/Farsi.isl Outdated
Comment thread Files/Languages/Unofficial/Farsi.isl Outdated
Comment thread Files/Languages/Unofficial/Farsi.isl Outdated
Comment thread Files/Languages/Unofficial/Farsi.isl Outdated
Comment thread Files/Languages/Unofficial/Farsi.isl Outdated
Comment thread Files/Languages/Unofficial/Farsi.isl Outdated
Comment thread Files/Languages/Unofficial/Farsi.isl Outdated
Comment thread Files/Languages/Unofficial/Farsi.isl Outdated
@Blackspirits

Copy link
Copy Markdown
Contributor Author

Thank you very much for the detailed native review.

I agree that the disputed stylistic changes, including the systematic use of
half-spaces, should be left to you as the translation maintainer.

I will keep only the objective technical and linguistic fixes that you
confirmed, such as the missing placeholder and the omitted Setup reference,
and revert the changes you identified as incorrect or unnecessary.

I will wait for @martijnlaan to confirm the preferred workflow. If the Persian
translation should be maintained through your repository, I will submit a
small focused pull request there containing only the mutually accepted fixes.
Otherwise, I will reduce this pull request to those same confirmed corrections.

Thank you again for taking the time to review everything.

@peymanr34

Copy link
Copy Markdown

@Blackspirits No worries, thanks for your contribution.

@martijnlaan

Copy link
Copy Markdown
Member

I have no preference for the workflow.

@Blackspirits Blackspirits changed the title Update and review Farsi translation for Inno Setup 6.5.0+ Fix three confirmed Farsi translation issues Jul 12, 2026
@Blackspirits

Copy link
Copy Markdown
Contributor Author

I have reduced this pull request to the three changes confirmed in the native review:

  • LanguageName=فارسی;
  • the omitted Setup reference in SetupAppRunningError;
  • the missing %1 placeholder in ErrorFileSize.

All disputed stylistic, half-space, punctuation, and wording changes have been reverted. The previous review threads are now outdated because those changes are no longer part of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants