Fix three confirmed Farsi translation issues#612
Conversation
|
I have also contacted Peyman Mohammadi, the original translator listed in the file, by email and asked him to review the proposed changes. I will update this PR if I receive any corrections or confirmation from him. |
|
This is the response I sent to your email @Blackspirits:
|
peymanr34
left a comment
There was a problem hiding this comment.
Thank you for:
- Changing the
LanguageNameto match the other translations. - Catching the missing %1 on line 225
- Catching the missing "setup" translation on line 74.
- And other improvements.
But a lot of the proposed changes are opinionated, especially the excessive use of the half-spaces. The half-spaces are technically correct however I deliberately didn't used them because on non-native fonts like "Segue UI" and previously "Tahoma", they arguably make the messages harder to read.
If @martijnlaan aggress with me, please submit the requested changes to my repo. If not I'll go ahead and make the changes on your behalf (with proper attributions of course).
|
Thank you very much for the detailed native review. I agree that the disputed stylistic changes, including the systematic use of I will keep only the objective technical and linguistic fixes that you I will wait for @martijnlaan to confirm the preferred workflow. If the Persian Thank you again for taking the time to review everything. |
|
@Blackspirits No worries, thanks for your contribution. |
|
I have no preference for the workflow. |
|
I have reduced this pull request to the three changes confirmed in the native review:
All disputed stylistic, half-space, punctuation, and wording changes have been reverted. The previous review threads are now outdated because those changes are no longer part of the pull request. |
This pull request now contains only three focused changes confirmed by the native Farsi translation maintainer:
LanguageNamefromFarsitoفارسی, matching the naming style used by other translations;SetupAppRunningError;%1placeholder inErrorFileSize.All disputed stylistic changes, including the systematic half-space changes and other wording changes, have been reverted. The translation remains under
Files/Languages/Unofficialas intended by its maintainer.Validation:
Files/Languages/Unofficial/Farsi.islis changed;