Point the bundle-release workflow at the diplicity-react service - #1316
Open
johnpooch wants to merge 1 commit into
Open
Point the bundle-release workflow at the diplicity-react service#1316johnpooch wants to merge 1 commit into
johnpooch wants to merge 1 commit into
Conversation
railway run --service took diplicity-react-production, which is the deploy domain prefix rather than a service name, so the publish step fails with "Service not found" once it gets past authentication. Verified against the live project: --service=diplicity-react resolves and reports environment production, --service=diplicity-react-production does not resolve, and omitting the flag reports multiple services. The name was carried over from build-and-deploy-service.yml, which passes the same string to railway up without complaint. railway up is more forgiving about the service name than railway run, so that workflow working is not evidence the name is right. Recorded in the ota-releases rule so the next workflow does not copy it again. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CMxVHZUhpRht949vkWiDD3
Contributor
|
Warning WIP limit exceeded. There are now 9 open pull requests — the project target is 5 or fewer. Please close or merge an existing PR before continuing with this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
bundle-release.ymlpassed--service=diplicity-react-productiontorailway run. That is the deploy domain prefix (diplicity-react-production.up.railway.app), not a service name, so the publish step cannot resolve it. Points it atdiplicity-reactinstead.Verified against the live project with a project-scoped token:
railway run --service=diplicity-react-productionService not founddiplicity-reactproductionMultiple services foundThe name was carried over from
build-and-deploy-service.yml:19, which passes the same string torailway upand deploysmainwithout complaint.railway upis more forgiving about the service name thanrailway runis, so that workflow succeeding is not evidence the name is correct — which is how this got through review on #1304.Recorded in
.claude/rules/backend/ota-releases.mdso the next workflow doesn't copy the name from a deploy workflow and assume it's right.Not fixed here
The first dispatch of this workflow (run 34062490563) failed earlier than this, on authentication:
That is upstream of the service lookup and is a secret-configuration problem, not a code one —
railway runneeds a project-scoped token inRAILWAY_TOKEN, while an account token belongs inRAILWAY_API_TOKEN(the split is documented in.claude/skills/production/SKILL.md). This PR does not address it; the token has to be right before the corrected service name gets exercised.build-and-deploy-service.ymlstill passes the same non-existent service name torailway up. Its post-deploy version check passes, so deploys are landing somewhere real and nothing is visibly broken — left alone deliberately rather than changed on a hunch.Checklist
/review-pragainst this PR in Claude Code and addressed (or responded to) its findings — not applicable; this is a one-token change to a workflow, verified directly against the Railway CLI rather than by reviewworkflow_dispatchjob guarded onmain. Verified by runningrailway run --serviceagainst the live project, as tabulated above. YAML re-parsed after the edit.🤖 Generated with Claude Code
https://claude.ai/code/session_01CMxVHZUhpRht949vkWiDD3
Generated by Claude Code