Skip to content

Updates to get Novel Engine to work on Windows. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrislondon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updates to get Novel Engine to work on Windows. #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/infrastructure/claude-cli/ClaudeCodeClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ import { execFile } from 'child_process';
import { promisify } from 'util';
import path from 'node:path';
import { nanoid } from 'nanoid';
import { tmpdir } from 'os';
import { join } from 'path';
import { writeFileSync, unlinkSync } from 'fs';

import type { IClaudeClient, IModelProvider, IDatabaseService } from '@domain/interfaces';
import type { MessageRole, StreamEvent, ProviderCapability, ProviderId } from '@domain/types';
Expand Down Expand Up @@ -44,7 +47,7 @@ export class ClaudeCodeClient implements IClaudeClient, IModelProvider {
async isAvailable(): Promise<boolean> {
if (this._available !== null) return this._available;
try {
await execFileAsync('claude', ['--version']);
await execFileAsync('claude', ['--version'], { shell: process.platform === 'win32' });
this._available = true;
return true;
} catch {
Expand Down Expand Up @@ -191,13 +194,17 @@ export class ClaudeCodeClient implements IClaudeClient, IModelProvider {
// Build conversation prompt from message history
const conversationPrompt = this.buildConversationPrompt(messages);

// Save system prompt to a temporary file and pass the path to the CLI, since it may exceed command-line length limits.
const tmpSystemPromptFile = join(tmpdir(), `claude-system-${Date.now()}.txt`);
writeFileSync(tmpSystemPromptFile, systemPrompt, 'utf8');

const args = [
'--print',
'--output-format', 'stream-json',
'--verbose',
'--model', model,
'--max-turns', String(params.maxTurns ?? 30),
'--system-prompt', systemPrompt,
'--system-prompt-file', tmpSystemPromptFile, // <-- file instead of inline
'--allowedTools', 'Read,Write,Edit,LS,Bash(mkdir:*),Bash(cat:*),Bash(mv:*),Bash(cp:*),Bash(ls:*),Bash(find:*),Bash(wc:*),Bash(rm:*),Bash(rmdir:*)',
'--add-dir', this.booksDir,
];
Expand All @@ -216,24 +223,14 @@ export class ClaudeCodeClient implements IClaudeClient, IModelProvider {
? path.join(this.booksDir, bookSlug)
: undefined;

// Guard against system prompts that would exceed the OS argument size limit.
// Most systems support 128KB-2MB for total argv. We cap the system prompt at
// 500KB to leave room for other arguments.
const MAX_SYSTEM_PROMPT_BYTES = 500_000;
const promptBytes = Buffer.byteLength(systemPrompt, 'utf-8');
if (promptBytes > MAX_SYSTEM_PROMPT_BYTES) {
const message = `System prompt exceeds ${MAX_SYSTEM_PROMPT_BYTES / 1000}KB limit (actual: ${Math.round(promptBytes / 1000)}KB). Check the agent .md file for excessive content.`;
params.onEvent({ type: 'error', message });
return;
}

console.log(`[ClaudeCodeClient] Spawning CLI: model=${model}, cwd=${cwd ?? '(none)'}, conversationId=${conversationId}, args=${args.length} items`);

return new Promise<void>((resolve, reject) => {
const child = spawn('claude', args, {
stdio: ['pipe', 'pipe', 'pipe'],
env: { ...process.env },
cwd,
shell: process.platform === 'win32', // Use shell on Windows to resolve .cmd/.exe from PATH
});

console.log(`[ClaudeCodeClient] CLI spawned: pid=${child.pid ?? 'unknown'}, conversationId=${conversationId}`);
Expand Down Expand Up @@ -304,6 +301,9 @@ export class ClaudeCodeClient implements IClaudeClient, IModelProvider {
});

child.on('close', (code) => {
// Remove temporary system prompt file
try { unlinkSync(tmpSystemPromptFile); } catch {}

// Flush any buffered events before processing the close
flushBatch();

Expand Down
2 changes: 1 addition & 1 deletion src/infrastructure/settings/SettingsService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export class SettingsService implements ISettingsService {
try {
// Only use --version — `claude doctor` is interactive (prompts "Press Enter")
// and will hang indefinitely when called from a child process with no stdin.
const { stdout } = await execFile('claude', ['--version'], { timeout: 10_000 });
const { stdout } = await execFile('claude', ['--version'], { timeout: 10_000, shell: process.platform === 'win32' });
const found = stdout.trim().length > 0;
await this.update({ hasClaudeCli: found });
return found;
Expand Down