Updates to get Novel Engine to work on Windows. - #6
Open
chrislondon wants to merge 1 commit into
Open
Conversation
… Windows is very restrictive and doesn't allow very long system arguments. To avoid this issue we're going to write the system prompt to a fileand pass the file to Claude. We also attempt to clean up the temp file afterward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On windows systems we need to set the 'shell' parameter to true. Also Windows is very restrictive and doesn't allow very long system arguments. To avoid this issue we're going to write the system prompt to a file and pass the file to Claude. We also attempt to clean up the temp file afterward