Sourcery Starbot ⭐ refactored Style77/quantex

quantex-scraper/__main__.py

@@ -23,10 +23,7 @@
 
 def get_chromedriver_path():
     current_directory = os.path.dirname(os.path.abspath(__file__))
-    chromedriver_path = os.path.join(
-        current_directory, "driver", "chromedriver"
-    )
-    return chromedriver_path
+    return os.path.join(current_directory, "driver", "chromedriver")
 
 
 def convert_relative_timestamp(timestamp):
@@ -48,22 +45,20 @@ def convert_relative_timestamp(timestamp):
     unit = timestamp[-1]
 
     # Define the time delta based on the unit
-    if unit == "s":
-        delta = timedelta(seconds=int(value))
-    elif unit == "m":
-        delta = timedelta(minutes=int(value))
+    if unit == "d":
+        delta = timedelta(days=int(value))
     elif unit == "h":
         delta = timedelta(hours=int(value))
-    elif unit == "d":
-        delta = timedelta(days=int(value))
+    elif unit == "m":
+        delta = timedelta(minutes=int(value))
+    elif unit == "s":
+        delta = timedelta(seconds=int(value))
     elif unit == "w":
         delta = timedelta(weeks=int(value))
     else:
         raise ValueError("Invalid timestamp unit")
 
-    normal_datetime = datetime.now() - delta
-
-    return normal_datetime
+    return datetime.now() - delta
 
 
 class NewsScraper:
@@ -419,7 +414,7 @@ def scrape(self, with_a: bool = True):
             }
             results.append(data)
 
-        if len(results) > 0:
+        if results:
             self.logger.info(f"Scraped {len(results)} articles")
         else:
             self.logger.warning("No articles scraped")
@@ -511,12 +506,11 @@ def preconfigure():
     if not user or not password:
         raise Exception("Missing user or password")
 
-    edenai_key = os.getenv("QUANTEX_EDENAI_API_KEY")
-    if not edenai_key:
+    if edenai_key := os.getenv("QUANTEX_EDENAI_API_KEY"):
+        return user, password, edenai_key
+    else:
         raise Exception("Missing EdenAI API key")
 
-    return user, password, edenai_key
-
 
 @listener.on("unique_data")
 def on_unique_data(item: list):

quantex-scraper/telegram.py

@@ -5,9 +5,9 @@
 class TelegramBot:
     def __init__(self, token):
         self.token = token
-        self.api_url = "https://api.telegram.org/bot{}/".format(token)
+        self.api_url = f"https://api.telegram.org/bot{token}/"
 
     def send_message(self, chat: str, text: str):
         data = {"chat_id": chat, "text": text, "parse_mode": "markdown"}
-        r = requests.post(self.api_url + "sendMessage", data=data)
+        r = requests.post(f"{self.api_url}sendMessage", data=data)
         return r.json()

quantex/database/dao/news_dao.py

@@ -33,12 +33,12 @@ async def get_news(self, news_id: int) -> typing.List[NewsModelDTO]:
         """Get news by id."""
         query = select(NewsModel).where(NewsModel.id == news_id)
         r = await self.session.execute(query)
-        news = r.scalars().first()
-        if not news:
+        if news := r.scalars().first():
+            return [NewsModelDTO.from_orm(news)]
+        else:
             raise HTTPException(
                 status_code=status.HTTP_404_NOT_FOUND, detail="News not found"
             )
-        return [NewsModelDTO.from_orm(news)]
 
     async def get_many_news(
         self,

quantex/web/lifetime.py

@@ -49,7 +49,6 @@ def register_startup_event(
     @app.on_event("startup")
     async def _startup() -> None:
         _setup_db(app)
-        pass
 
     return _startup
 
@@ -68,6 +67,4 @@ def register_shutdown_event(
     async def _shutdown() -> None:
         await app.state.db_engine.dispose()
 
-        pass
-
     return _shutdown