Sourcery Starbot ⭐ refactored Style77/quantex - #1
Open
SourceryAI wants to merge 1 commit into
Open
Conversation
SourceryAI
commented
Nov 15, 2023
Comment on lines
-36
to
-41
| news = r.scalars().first() | ||
| if not news: | ||
| if news := r.scalars().first(): | ||
| return [NewsModelDTO.from_orm(news)] | ||
| else: | ||
| raise HTTPException( | ||
| status_code=status.HTTP_404_NOT_FOUND, detail="News not found" | ||
| ) | ||
| return [NewsModelDTO.from_orm(news)] |
Author
There was a problem hiding this comment.
Function NewsDAO.get_news refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Lift code into else after jump in control flow (
reintroduce-else) - Swap if/else branches (
swap-if-else-branches)
| @app.on_event("startup") | ||
| async def _startup() -> None: | ||
| _setup_db(app) | ||
| pass |
Author
There was a problem hiding this comment.
Function register_startup_event refactored with the following changes:
- Remove redundant pass statement (
remove-redundant-pass)
Comment on lines
-71
to
-72
| pass | ||
|
|
Author
There was a problem hiding this comment.
Function register_shutdown_event refactored with the following changes:
- Remove redundant pass statement (
remove-redundant-pass)
| current_directory, "driver", "chromedriver" | ||
| ) | ||
| return chromedriver_path | ||
| return os.path.join(current_directory, "driver", "chromedriver") |
Author
There was a problem hiding this comment.
Function get_chromedriver_path refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-51
to
+61
| if unit == "s": | ||
| delta = timedelta(seconds=int(value)) | ||
| elif unit == "m": | ||
| delta = timedelta(minutes=int(value)) | ||
| if unit == "d": | ||
| delta = timedelta(days=int(value)) | ||
| elif unit == "h": | ||
| delta = timedelta(hours=int(value)) | ||
| elif unit == "d": | ||
| delta = timedelta(days=int(value)) | ||
| elif unit == "m": | ||
| delta = timedelta(minutes=int(value)) | ||
| elif unit == "s": | ||
| delta = timedelta(seconds=int(value)) | ||
| elif unit == "w": | ||
| delta = timedelta(weeks=int(value)) | ||
| else: | ||
| raise ValueError("Invalid timestamp unit") | ||
|
|
||
| normal_datetime = datetime.now() - delta | ||
|
|
||
| return normal_datetime | ||
| return datetime.now() - delta |
Author
There was a problem hiding this comment.
Function convert_relative_timestamp refactored with the following changes:
- Simplify conditional into switch-like form [×2] (
switch) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-422
to
+417
| if len(results) > 0: | ||
| if results: |
Author
There was a problem hiding this comment.
Function NewsScraper.scrape refactored with the following changes:
- Simplify sequence length comparison (
simplify-len-comparison)
Comment on lines
-514
to
-518
| edenai_key = os.getenv("QUANTEX_EDENAI_API_KEY") | ||
| if not edenai_key: | ||
| if edenai_key := os.getenv("QUANTEX_EDENAI_API_KEY"): | ||
| return user, password, edenai_key | ||
| else: | ||
| raise Exception("Missing EdenAI API key") | ||
|
|
||
| return user, password, edenai_key |
Author
There was a problem hiding this comment.
Function preconfigure refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Lift code into else after jump in control flow (
reintroduce-else) - Swap if/else branches (
swap-if-else-branches)
| def __init__(self, token): | ||
| self.token = token | ||
| self.api_url = "https://api.telegram.org/bot{}/".format(token) | ||
| self.api_url = f"https://api.telegram.org/bot{token}/" |
Author
There was a problem hiding this comment.
Function TelegramBot.__init__ refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
| def send_message(self, chat: str, text: str): | ||
| data = {"chat_id": chat, "text": text, "parse_mode": "markdown"} | ||
| r = requests.post(self.api_url + "sendMessage", data=data) | ||
| r = requests.post(f"{self.api_url}sendMessage", data=data) |
Author
There was a problem hiding this comment.
Function TelegramBot.send_message refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
developbranch, then run: