Forge 1.20.1 backport w/ Enchant - #121
Conversation
|
That's a consequence of my (admittedly awful) process. I had downloaded the three versions onto my desktop (fabric 1.21.4, the recent pull request backporting the major features to fabric 1.20.1, and the base forge 1.20.1 architecture (which needed a lot of love anyway)). Unfortunately, I didn't realize I should have started with a fork, and then cloned that- So I rewrote all of the code locally, then made the github fork, which caused me to make a new branch on my fork to compare to the original project, and I needed to edit the vast majority of the files to un-bugger the mixins I converted anyway! Honestly, it was a disaster the whole way down, and I should be imprisoned for the way I integrated the Curios API. Nonetheless, it should work just fine... Is there a spot I should submit the .jar itself? |
|
@CephaoftheDromes Hey! Can you please send me the finished .jar file? I can't get it to build and would like to try it out. Thanks! |
|
@CephaoftheDromes I'm struggling to build the jar file using gradlew.bat, does it work on your machine? |
|
@Martin-exe-v2 It worked on my machine, but I had to do some roundabout nonsense to specify the java path manually. If you could create a working fork, that'd be swell. @Jakubman625 Pre-compiled Jar file can be found hosted on [https://mega.nz/file/yYkHBJaQ#ugXAee4cZEtmHAVhtDORcpEbUL5Bzby7-W9g_4shsts], as well for anybody else who wants to try it. |
|
@CephaoftheDromes Thank you so much for the Jar file! I really appreciate it! :) i was trying to build it myself, but ended up with sooo many issues. |
|
@CephaoftheDromes Hey! |
|
@Jakubman625 thanks for the heads up! I'm not intimately familiar with the exact specifics of the mod tbh. I'll look into it. |
|
Cepha, i have been playing with this for about 2 weeks testing. I think only changes needed tbh are if you could fix the collared player being able to break invisible fences, and the lead breaking upon disconnect in a server environment. Other then that, no issues really exist from my testing. Oh, the paw control device doesn't work as well but thats not that big of a deal |
God forbid github make intuitive sense for once.
Didn't forget the enchants this time. They might work. They might not. I didn't have a sacrificial dummy to test them on.
If this pull request should (unshockingly) fail, the v1.6/1.20.1 Forge backport can be found at https://github.com/CephaoftheDromes/PlayerCollars.