Skip to content

Support badge-plugin 3.x - #191

Open
strangelookingnerd wants to merge 5 commits into
jenkinsci:masterfrom
strangelookingnerd:badge-migration
Open

Support badge-plugin 3.x#191
strangelookingnerd wants to merge 5 commits into
jenkinsci:masterfrom
strangelookingnerd:badge-migration

Conversation

@strangelookingnerd

@strangelookingnerd strangelookingnerd commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Follow-up for #190, fixing compatibility with badge-plugin 3.x (see jenkinsci/badge-plugin#304)

  • Replace deprecated methods with non-deprecated ones
  • Add migrator for badges
  • Use the latest bom containing the latest badge plugin 3.x

Testing done

Fixed failing tests, mvn clean verify works fine.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@strangelookingnerd
strangelookingnerd marked this pull request as ready for review March 29, 2026 14:39
@strangelookingnerd
strangelookingnerd requested a review from a team as a code owner March 29, 2026 14:39
MarkEWaite added a commit to MarkEWaite/bom that referenced this pull request Apr 1, 2026
@hype-kb

hype-kb commented Apr 23, 2026

Copy link
Copy Markdown

Hi @MarkEWaite and @strangelookingnerd - is there anything I can help with to get this PR merged?

@MarkEWaite

Copy link
Copy Markdown
Contributor

Hi @MarkEWaite and @strangelookingnerd - is there anything I can help with to get this PR merged?

Install the incremental build from the pull request (see the instructions) and report your results.

@gjabouley-invn

gjabouley-invn commented Jul 9, 2026

Copy link
Copy Markdown

Hello, would be interested in helping moving forward on this PR.
I cloned the repo, and was able to build locally, so not sure why build is failing here...

[ERROR] /home/jenkins/agent/workspace/s_groovy-postbuild-plugin_PR-191/src/test/java/org/jvnet/hudson/plugins/groovypostbuild/GroovyPostbuildRecorderTest.java:[454,6] cannot find symbol
  symbol:   class Disabled
  location: class org.jvnet.hudson.plugins.groovypostbuild.GroovyPostbuildRecorderTest
[ERROR] /home/jenkins/agent/workspace/s_groovy-postbuild-plugin_PR-191/src/test/java/org/jvnet/hudson/plugins/groovypostbuild/GroovyPostbuildRecorderTest.java:[693,6] cannot find symbol
  symbol:   class Disabled
  location: class org.jvnet.hudson.plugins.groovypostbuild.GroovyPostbuildRecorderTest

@MarkEWaite

Copy link
Copy Markdown
Contributor

Hello, would be interested in helping moving forward on this PR. I cloned the repo, and was able to build locally, so not sure why build is failing here...

[ERROR] /home/jenkins/agent/workspace/s_groovy-postbuild-plugin_PR-191/src/test/java/org/jvnet/hudson/plugins/groovypostbuild/GroovyPostbuildRecorderTest.java:[454,6] cannot find symbol
  symbol:   class Disabled
  location: class org.jvnet.hudson.plugins.groovypostbuild.GroovyPostbuildRecorderTest
[ERROR] /home/jenkins/agent/workspace/s_groovy-postbuild-plugin_PR-191/src/test/java/org/jvnet/hudson/plugins/groovypostbuild/GroovyPostbuildRecorderTest.java:[693,6] cannot find symbol
  symbol:   class Disabled
  location: class org.jvnet.hudson.plugins.groovypostbuild.GroovyPostbuildRecorderTest

The build of the pull request fails consistently for me on my RHEL 8.10 system with JDK 21.0.11 and Apache Maven 3.9.16. The failure message is:

[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/mwaite/hub/orphans/groovy-postbuild-plugin/src/test/java/org/jvnet/hudson/plugins/groovypostbuild/GroovyPostbuildRecorderTest.java:[454,6] cannot find symbol
  symbol:   class Disabled
  location: class org.jvnet.hudson.plugins.groovypostbuild.GroovyPostbuildRecorderTest
[ERROR] /home/mwaite/hub/orphans/groovy-postbuild-plugin/src/test/java/org/jvnet/hudson/plugins/groovypostbuild/GroovyPostbuildRecorderTest.java:[693,6] cannot find symbol
  symbol:   class Disabled
  location: class org.jvnet.hudson.plugins.groovypostbuild.GroovyPostbuildRecorderTest
[INFO] 2 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  2.791 s
[INFO] Finished at: 2026-07-09T05:57:05-06:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.15.0:testCompile (default-testCompile) on project groovy-postbuild: Compilation failure: Compilation failure:
[ERROR] /home/mwaite/hub/orphans/groovy-postbuild-plugin/src/test/java/org/jvnet/hudson/plugins/groovypostbuild/GroovyPostbuildRecorderTest.java:[454,6] cannot find symbol
[ERROR]   symbol:   class Disabled
[ERROR]   location: class org.jvnet.hudson.plugins.groovypostbuild.GroovyPostbuildRecorderTest
[ERROR] /home/mwaite/hub/orphans/groovy-postbuild-plugin/src/test/java/org/jvnet/hudson/plugins/groovypostbuild/GroovyPostbuildRecorderTest.java:[693,6] cannot find symbol
[ERROR]   symbol:   class Disabled
[ERROR]   location: class org.jvnet.hudson.plugins.groovypostbuild.GroovyPostbuildRecorderTest

That is the same failure message that is visible on ci.jenkins.io

@olivierdagenais

Copy link
Copy Markdown
Member

The code changes appear fine. I'll try to install it in a Jenkins instance at $WORK and run some tests there; please stand by.

@olivierdagenais olivierdagenais left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, on Jenkins LTS 2.541.3, I upgraded Badge from 2.562.vc3c0b_6925377 to 3.591.v9074c6c6f0b_9, installed the .hpi generated by building the code from this branch/PR and ran our battery of end-to-end tests...with success!

Approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants