Support badge-plugin 3.x - #191
Conversation
|
Hi @MarkEWaite and @strangelookingnerd - is there anything I can help with to get this PR merged? |
Install the incremental build from the pull request (see the instructions) and report your results. |
|
Hello, would be interested in helping moving forward on this PR. |
The build of the pull request fails consistently for me on my RHEL 8.10 system with JDK 21.0.11 and Apache Maven 3.9.16. The failure message is: That is the same failure message that is visible on ci.jenkins.io |
|
The code changes appear fine. I'll try to install it in a Jenkins instance at $WORK and run some tests there; please stand by. |
olivierdagenais
left a comment
There was a problem hiding this comment.
OK, on Jenkins LTS 2.541.3, I upgraded Badge from 2.562.vc3c0b_6925377 to 3.591.v9074c6c6f0b_9, installed the .hpi generated by building the code from this branch/PR and ran our battery of end-to-end tests...with success!
Approved!
Follow-up for #190, fixing compatibility with badge-plugin 3.x (see jenkinsci/badge-plugin#304)
Testing done
Fixed failing tests,
mvn clean verifyworks fine.Submitter checklist