Skip to content

Revert to addSummary as gradle plugin not supported in badge plugin 3.583.vdc8d4a_a_1d586 - #7109

Merged
JasonFengJ9 merged 1 commit into
adoptium:masterfrom
annaibm:updateSum
May 12, 2026
Merged

Revert to addSummary as gradle plugin not supported in badge plugin 3.583.vdc8d4a_a_1d586#7109
JasonFengJ9 merged 1 commit into
adoptium:masterfrom
annaibm:updateSum

Conversation

@annaibm

@annaibm annaibm commented May 12, 2026

Copy link
Copy Markdown
Contributor

Revert to addSummary as gradle plugin not supported for new badge plugin 3.583.vdc8d4a_a_1d586

@annaibm

annaibm commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Grinder test:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/59963/ ✅

Before : -> with badge plugin update -
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/59960/

12:47:29  Exception: groovy.lang.MissingMethodException: No signature of method: org.jvnet.hudson.plugins.groovypostbuild.GroovyPostbuildRecorder$BadgeManager.addSummary() is applicable for argument types: (java.lang.String) values: [accept.svg]

@annaibm annaibm mentioned this pull request May 12, 2026
Merged
@annaibm

annaibm commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

@smlambert @pshipton Kindly review . the Badge plugin update in PR #7108 is causing pipeline failures because the groovy-postbuild plugin doesn't support the new API yet — fix is still pending upstream at jenkinsci/groovy-postbuild-plugin#191. (https://plugins.jenkins.io/badge/releases/)

@JasonFengJ9
JasonFengJ9 merged commit 8b5effa into adoptium:master May 12, 2026
2 checks passed
@JasonFengJ9

JasonFengJ9 commented May 12, 2026

Copy link
Copy Markdown
Contributor

@smlambert feel free to request further changes if necessary.

@smlambert

smlambert commented May 12, 2026

Copy link
Copy Markdown
Contributor

FYI @steelhead31

keithc-ca
keithc-ca reviewed May 12, 2026
View reviewed changes
Comment thread buildenv/jenkins/JenkinsfileBase
summary = manager.createSummary("warning.svg")
} else {
summary = manager.addSummary("accept.svg")
summary = manager.createSummary("accept.svg")

@keithc-ca keithc-ca May 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it that only these two uses of addSummary need to change? Why not lines 890 and 906?

@annaibm annaibm May 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Keith, all addSummary should be reverted. Was testing the errored ones first! Will update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JasonFengJ9 JasonFengJ9 JasonFengJ9 approved these changes
@pshipton pshipton pshipton approved these changes
+1 more reviewer
@keithc-ca keithc-ca keithc-ca left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@annaibm @JasonFengJ9 @smlambert @keithc-ca @pshipton