Add 2.555.x line, remove 2.516.x line #6540
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <parent> | ||
| <groupId>io.jenkins.tools.bom</groupId> | ||
| <artifactId>parent</artifactId> | ||
| <version>${changelist}</version> | ||
| </parent> | ||
| <artifactId>bom-2.555.x</artifactId> | ||
| <packaging>pom</packaging> | ||
| <properties> | ||
| <workflow-job-plugin.version>1571.vb_423c255d6d9</workflow-job-plugin.version> | ||
| </properties> | ||
|
Comment on lines
+11
to
+13
Member
There was a problem hiding this comment. I am not sure if we need this or just <properties />
Member
There was a problem hiding this comment. We need because of the "normal" and
Contributor
There was a problem hiding this comment. We need it because the workflow-job plugin is a special case. The most recent release requires Jenkins 2.556 or newer. |
||
| <dependencyManagement> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>${project.groupId}</groupId> | ||
| <artifactId>bom-weekly</artifactId> | ||
| <version>${project.version}</version> | ||
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins.workflow</groupId> | ||
| <artifactId>workflow-job</artifactId> | ||
| <version>${workflow-job-plugin.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins.workflow</groupId> | ||
| <artifactId>workflow-job</artifactId> | ||
| <version>${workflow-job-plugin.version}</version> | ||
| <classifier>tests</classifier> | ||
| </dependency> | ||
|
Comment on lines
+23
to
+33
Member
There was a problem hiding this comment. I am not sure we need these, and why is the same dependency duplicated?
Member
There was a problem hiding this comment. These are not the same. From Maven documentation:
Technically, the
Contributor
There was a problem hiding this comment. We need both because one is the production dependency and the other is the test dependency. The workflow-job plugin is an uncommon plugin (like the git plugin). It provides both a production jar and a test jar. Both the production jar and the test jar are used by other plugins
Member
There was a problem hiding this comment. Thanks! Sorry I missed the |
||
| </dependencies> | ||
| </dependencyManagement> | ||
| </project> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these lines removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because they have moved into the bom-2.555.x line. We don't want to duplicate the dependencies when we can inherit them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#6744 (comment)