Skip to content

Add 2.555.x line, remove 2.516.x line - #6540

Merged
krisstern merged 12 commits into
jenkinsci:masterfrom
shalinisudarsan:chore/fix-jenkins-version-2.555.1
Apr 1, 2026
Merged

Add 2.555.x line, remove 2.516.x line#6540
krisstern merged 12 commits into
jenkinsci:masterfrom
shalinisudarsan:chore/fix-jenkins-version-2.555.1

Conversation

@shalinisudarsan

@shalinisudarsan shalinisudarsan commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

update jenkins version to 2.555.1

Testing done

Successfully ran:

LINE=2.555.x PLUGINS=git,git-client TEST=InjectedTest bash ./local-test.sh

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

update jenkins version to 2.555.1
@shalinisudarsan
shalinisudarsan requested a review from a team as a code owner March 30, 2026 15:19
@krisstern

Copy link
Copy Markdown
Member

Hi @shalinisudarsan you forgot to remove the oldest baseline so that the total number of baselines is 3

@krisstern krisstern added the chore Reduces future maintenance label Mar 30, 2026
@krisstern

Copy link
Copy Markdown
Member

We need to do something like this from before:
#6198

@shalinisudarsan shalinisudarsan changed the title update jenkins version to 2.555.1 Add 2.555.x line, remove 2.516.x line Mar 30, 2026
@lemeurherve

Copy link
Copy Markdown
Member

No testing done?

@krisstern krisstern added full-test Test all LTS lines in this PR and do not halt upon first error. and removed full-test Test all LTS lines in this PR and do not halt upon first error. labels Mar 30, 2026
@krisstern

Copy link
Copy Markdown
Member

Yes, just added the full-test label

Added 2.555.x, remove 2.516.x
@lemeurherve

Copy link
Copy Markdown
Member

Yes, just added the full-test label

I mean, local testing done before opening the PR.

@krisstern

Copy link
Copy Markdown
Member

Sorry, I misunderstood

@krisstern

Copy link
Copy Markdown
Member

@shalinisudarsan could you please check locally before pushing again?

Updated version for deprecated baseline
Comment thread bom-2.555.x/pom.xml
Comment on lines +11 to +13
<properties>
<workflow-job-plugin.version>1571.vb_423c255d6d9</workflow-job-plugin.version>
</properties>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we need this or just

  <properties />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need because of the "normal" and tests classifiers.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need it because the workflow-job plugin is a special case. The most recent release requires Jenkins 2.556 or newer.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Now I see

Comment thread bom-2.555.x/pom.xml
Comment on lines +23 to +33
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-job</artifactId>
<version>${workflow-job-plugin.version}</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-job</artifactId>
<version>${workflow-job-plugin.version}</version>
<classifier>tests</classifier>
</dependency>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we need these, and why is the same dependency duplicated?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not the same. From Maven documentation:

: The classifier distinguishes artifacts that were built from the same POM but differ in content. It is some optional and arbitrary string that - if present - is appended to the artifact name just after the version number.

Technically, the tests classifier means that it's a JAR that contains the src/test/** content. This is useful when a you can mutualize the test setup for example.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need both because one is the production dependency and the other is the test dependency. The workflow-job plugin is an uncommon plugin (like the git plugin). It provides both a production jar and a test jar. Both the production jar and the test jar are used by other plugins

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry I missed the tests part

Comment thread bom-2.541.x/pom.xml Outdated
Comment thread bom-2.541.x/pom.xml
Comment on lines -23 to -33
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-job</artifactId>
<version>${workflow-job-plugin.version}</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-job</artifactId>
<version>${workflow-job-plugin.version}</version>
<classifier>tests</classifier>
</dependency>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these lines removed?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because they have moved into the bom-2.555.x line. We don't want to duplicate the dependencies when we can inherit them.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 👍🏼

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Kris Stern <88480540+krisstern@users.noreply.github.com>
Comment thread README.md Outdated

```xml
<jenkins.baseline>2.516</jenkins.baseline>
<jenkins.baseline>2.555</jenkins.baseline>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have 2.555.3 yet?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually this would have been updated to 2.528, the next in the line, rather than 2.555.

@MarkEWaite MarkEWaite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a documentation change to retain 2.528.x as the documentation example.

Comment thread README.md Outdated
Avoids issue that .3 release of newest line is not
available
@MarkEWaite
MarkEWaite self-requested a review March 30, 2026 16:57

@MarkEWaite MarkEWaite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, the change looks like it is complete and correct. When the tests finish, we'll know for sure.

@krisstern

Copy link
Copy Markdown
Member

@MarkEWaite is there anything additional we need to do before this pull request can be merged?

@MarkEWaite

Copy link
Copy Markdown
Contributor

@MarkEWaite is there anything additional we need to do before this pull request can be merged?

I would like a successful run of all tests before we merge, though I think we are very close to that. I'll update the branch and that will run the build.

@krisstern

Copy link
Copy Markdown
Member

All tests passing now 👍🏼

@krisstern
krisstern merged commit e924e27 into jenkinsci:master Apr 1, 2026
592 checks passed
@MarkEWaite MarkEWaite added breaking enhancement New feature or request and removed chore Reduces future maintenance breaking labels Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request full-test Test all LTS lines in this PR and do not halt upon first error.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants