Add 2.555.x line, remove 2.516.x line - #6540
Conversation
update jenkins version to 2.555.1
Remove previous baseline
…m/shalinisudarsan/bom into chore/fix-jenkins-version-2.555.1
|
Hi @shalinisudarsan you forgot to remove the oldest baseline so that the total number of baselines is 3 |
|
We need to do something like this from before: |
|
No testing done? |
|
Yes, just added the |
Added 2.555.x, remove 2.516.x
I mean, local testing done before opening the PR. |
|
Sorry, I misunderstood |
|
@shalinisudarsan could you please check locally before pushing again? |
Updated version for deprecated baseline
| <properties> | ||
| <workflow-job-plugin.version>1571.vb_423c255d6d9</workflow-job-plugin.version> | ||
| </properties> |
There was a problem hiding this comment.
I am not sure if we need this or just
<properties />There was a problem hiding this comment.
We need because of the "normal" and tests classifiers.
There was a problem hiding this comment.
We need it because the workflow-job plugin is a special case. The most recent release requires Jenkins 2.556 or newer.
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins.workflow</groupId> | ||
| <artifactId>workflow-job</artifactId> | ||
| <version>${workflow-job-plugin.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins.workflow</groupId> | ||
| <artifactId>workflow-job</artifactId> | ||
| <version>${workflow-job-plugin.version}</version> | ||
| <classifier>tests</classifier> | ||
| </dependency> |
There was a problem hiding this comment.
I am not sure we need these, and why is the same dependency duplicated?
There was a problem hiding this comment.
These are not the same. From Maven documentation:
: The classifier distinguishes artifacts that were built from the same POM but differ in content. It is some optional and arbitrary string that - if present - is appended to the artifact name just after the version number.
Technically, the tests classifier means that it's a JAR that contains the src/test/** content. This is useful when a you can mutualize the test setup for example.
There was a problem hiding this comment.
We need both because one is the production dependency and the other is the test dependency. The workflow-job plugin is an uncommon plugin (like the git plugin). It provides both a production jar and a test jar. Both the production jar and the test jar are used by other plugins
There was a problem hiding this comment.
Thanks! Sorry I missed the tests part
Latest release of workflow-job depends on 2.556
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins.workflow</groupId> | ||
| <artifactId>workflow-job</artifactId> | ||
| <version>${workflow-job-plugin.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins.workflow</groupId> | ||
| <artifactId>workflow-job</artifactId> | ||
| <version>${workflow-job-plugin.version}</version> | ||
| <classifier>tests</classifier> | ||
| </dependency> |
There was a problem hiding this comment.
Because they have moved into the bom-2.555.x line. We don't want to duplicate the dependencies when we can inherit them.
Co-authored-by: Kris Stern <88480540+krisstern@users.noreply.github.com>
|
|
||
| ```xml | ||
| <jenkins.baseline>2.516</jenkins.baseline> | ||
| <jenkins.baseline>2.555</jenkins.baseline> |
There was a problem hiding this comment.
I don't think we have 2.555.3 yet?
There was a problem hiding this comment.
Usually this would have been updated to 2.528, the next in the line, rather than 2.555.
MarkEWaite
left a comment
There was a problem hiding this comment.
Needs a documentation change to retain 2.528.x as the documentation example.
Avoids issue that .3 release of newest line is not available
MarkEWaite
left a comment
There was a problem hiding this comment.
As far as I can tell, the change looks like it is complete and correct. When the tests finish, we'll know for sure.
|
@MarkEWaite is there anything additional we need to do before this pull request can be merged? |
I would like a successful run of all tests before we merge, though I think we are very close to that. I'll update the branch and that will run the build. |
|
All tests passing now 👍🏼 |
update jenkins version to 2.555.1
Testing done
Successfully ran:
LINE=2.555.x PLUGINS=git,git-client TEST=InjectedTest bash ./local-test.shSubmitter checklist