feat(cli): publish native completions in packslip - #85
Conversation
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (9)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughBoth ChangesShell completion support
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This change adds Bash, Zsh, Fish, and PowerShell completion generation and release packaging for both CLIs. The documented commands and packaged resources are aligned, with no material current merge-readiness risk identified. Sequence Diagram(s)sequenceDiagram
participant ReleaseWorkflow
participant Pacvamp
participant PacvampRepo
participant ShellValidators
ReleaseWorkflow->>Pacvamp: Generate usage and completion scripts
ReleaseWorkflow->>PacvampRepo: Generate usage and completion scripts
ReleaseWorkflow->>ShellValidators: Validate bash, zsh, fish, and PowerShell output
ShellValidators-->>ReleaseWorkflow: Return validation results
ReleaseWorkflow->>ReleaseWorkflow: Package resources with packslip
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (7 skipped: 7 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c021a7b. Configure here.

Add native completion generation and callbacks to both
pacvampandpacvamp-repofor Bash, Zsh, Fish, and PowerShell. Publish all eight scripts and both CLI specifications, with each signed Packslip resource explicitly bound to its executable. Preserve the existing license resource and refresh the CLI references.Release publishing checks every script with its native shell parser and exercises each callback. Local generation, all eight callbacks and syntax checks, both binaries' unit tests, strict Clippy across their targets, formatting, and workflow lint pass.
Companion installer support: jdx/mise#12848. pacvamp has no published release yet, so this does not add a mise registry entry.
AI-assisted — Tool: Codex; model: OpenAI/GPT-6; version: unavailable.
Note
Low Risk
Changes are additive CLI and release packaging with validation gates; no auth, data, or install-path behavior changes at runtime.
Overview
Adds
completion <SHELL>(bash, zsh, fish, powershell) topacvampandpacvamp-repo, enabled viausage_rscompletion generation and earlycompletion_requesthandling before normal parsing.The release
packslipjob now extracts the musl binary, emits__usageKDL and per-shell scripts for both programs, validates non-empty output,__complete_word__callbacks, and native shell syntax (including PowerShell parse checks), uploadsresources/*to the GitHub release, and wires those assets into packslip alongside the existing license.CLI usage KDL and docs list the new subcommand.
Reviewed by Cursor Bugbot for commit af0f5f6. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
New Features
pacvampandpacvamp-repo.completion <SHELL>command.Documentation