Skip to content

feat: include option to force cordova inclusion #8576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markemer merged 6 commits into from
Aug 20, 2026
Merged

feat: include option to force cordova inclusion #8576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
90cd6ba
feat: include option to force cordova inclusion
markemer Aug 18, 2026
8935972
npm run fmt
markemer Aug 18, 2026
bce0fa0
fix test
markemer Aug 18, 2026
45bbf87
Fix missing forceCordova check
markemer Aug 20, 2026
22b15d7
Added a log if Cordova Support has been forced
markemer Aug 20, 2026
4e61b6b
npm run fmt
markemer Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions cli/src/android/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,15 @@ export async function updateAndroid(config: Config): Promise<void> {
printPlugins(capacitorPlugins, 'android');

const cordovaPlugins = plugins.filter((p) => getPluginType(p, platform) === PluginType.Cordova);
const enableCordova = cordovaPlugins.length > 0;
const enableCordova = cordovaPlugins.length > 0 || config.app.forceCordova;

await writePluginsJson(config, capacitorPlugins, enableCordova);
await removePluginsNativeFiles(config);
if (enableCordova) {
logger.info('Found Cordova Plugins: Including Android Cordova Support');
if (config.app.forceCordova) {
logger.info('Cordova support installation has been forced');
}
Comment on lines 44 to +48

@OS-pedrogustavobilro OS-pedrogustavobilro Aug 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: This if block logs "Found Cordova Plugins" even if there are 0 cordova plugins with config.app.forceCordova set to true, which might be misleading? Unless that's what you were going with.

(also applies to the iOS version of update.ts)

@markemer markemer Aug 20, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I really have to think about this language/logic a little, but I thought just "warning" (I did wan't to use warn, but I thought people might complain) when it's enabled and forced would be enough for now.

await copyPluginsNativeFiles(config, cordovaPlugins);
}
if (!(await pathExists(config.android.webDirAbs))) {
Expand Down Expand Up @@ -157,7 +160,7 @@ export async function installGradlePlugins(
);
}

const enableCordova = cordovaPlugins.length > 0;
const enableCordova = cordovaPlugins.length > 0 || config.app.forceCordova;

const capacitorAndroidPath = resolve(dirname(capacitorAndroidPackagePath), 'capacitor');
const capacitorCordovaAndroidPath = resolve(dirname(capacitorAndroidPackagePath), 'capacitor-cordova');
Expand Down
2 changes: 2 additions & 0 deletions cli/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export async function loadConfig(): Promise<Config> {
const appId = conf.extConfig.appId ?? '';
const appName = conf.extConfig.appName ?? '';
const webDir = conf.extConfig.webDir ?? 'www';
const forceCordova = conf.extConfig.forceCordovaInclusion ?? false;
const cli = await loadCLIConfig(cliRootDir);

const config: Config = {
Expand All @@ -66,6 +67,7 @@ export async function loadConfig(): Promise<Config> {
appName,
webDir,
webDirAbs: resolve(appRootDir, webDir),
forceCordova,
package: (await tryFn(readJSON, resolve(appRootDir, 'package.json'))) ?? {
name: appName,
version: '1.0.0',
Expand Down
9 changes: 9 additions & 0 deletions cli/src/declarations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,15 @@ export interface CapacitorConfig {
*/
initialFocus?: boolean;

/**
* If set, will include Cordova support libraries regardless
* of whether or not they are needed by plugins.
*
* @since 9.0.0
* @default false
*/
forceCordovaInclusion?: boolean;

android?: {
/**
* Specify a custom path to the native Android project.
Expand Down
1 change: 1 addition & 0 deletions cli/src/definitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ export interface AppConfig {
readonly extConfigName: string;
readonly extConfigFilePath: string;
readonly extConfig: ExternalConfig;
readonly forceCordova: boolean;
}

export interface AndroidConfig extends PlatformConfig {
Expand Down
5 changes: 4 additions & 1 deletion cli/src/ios/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,13 @@ export async function updateIOS(config: Config, deployment: boolean): Promise<vo
async function updatePluginFiles(config: Config, plugins: Plugin[], deployment: boolean) {
await removePluginsNativeFiles(config);
const cordovaPlugins = plugins.filter((p) => getPluginType(p, platform) === PluginType.Cordova);
const enableCordova = cordovaPlugins.length > 0;
const enableCordova = cordovaPlugins.length > 0 || config.app.forceCordova;

if (enableCordova) {
logger.info('Found Cordova Plugins: Including iOS Cordova Support');
Comment thread
markemer marked this conversation as resolved.
if (config.app.forceCordova) {
logger.info('Cordova support installation has been forced');
}
await copyPluginsNativeFiles(config, cordovaPlugins);
}

Expand Down
2 changes: 1 addition & 1 deletion cli/src/util/spm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export async function generatePackageText(config: Config, plugins: Plugin[]): Pr
const iosPlatformVersion = await getCapacitorPackageVersion(config, config.ios.name);
const iosVersion = getMajoriOSVersion(config);
const cordovaPlugins = await getCordovaPlugins(config, 'ios');
const enableCordova = cordovaPlugins.length > 0;
const enableCordova = cordovaPlugins.length > 0 || config.app.forceCordova;
const packageTraits = config.app.extConfig.experimental?.ios?.spm?.packageTraits ?? {};
const packageOptions = config.app.extConfig.experimental?.ios?.spm?.packageOptions ?? {};
const swiftToolsVersion = config.app.extConfig.experimental?.ios?.spm?.swiftToolsVersion ?? '5.9';
Expand Down
1 change: 1 addition & 0 deletions cli/test/framework-detection.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ describe('framework detection', () => {
appName: 'appName',
webDir: '',
webDirAbs: '',
forceCordova: false,
package: {
name: 'package-name',
version: '0.0.0',
Expand Down
Loading