Conversation
Signed-off-by: Mark Anderson <mark.anderson@outsystems.com>
OS-pedrogustavobilro
approved these changes
Aug 20, 2026
OS-pedrogustavobilro
left a comment
OS-pedrogustavobilro
left a comment
Contributor
There was a problem hiding this comment.
I tested with a few combination of Capacitor apps, everything seems to work fine!
Left an additional non-blocking comment about the logging, but approving the PR.
Comment on lines
44
to
+48
| if (enableCordova) { | ||
| logger.info('Found Cordova Plugins: Including Android Cordova Support'); | ||
| if (config.app.forceCordova) { | ||
| logger.info('Cordova support installation has been forced'); | ||
| } |
Contributor
There was a problem hiding this comment.
Minor: This if block logs "Found Cordova Plugins" even if there are 0 cordova plugins with config.app.forceCordova set to true, which might be misleading? Unless that's what you were going with.
(also applies to the iOS version of update.ts)
Member
Author
There was a problem hiding this comment.
Yeah, I really have to think about this language/logic a little, but I thought just "warning" (I did wan't to use warn, but I thought people might complain) when it's enabled and forced would be enough for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change Type
Rationale / Problems Fixed
Tests or Reproductions
Screenshots / Media
Platforms Affected
Notes / Comments