Save intermediate node input features - #1698
Merged
Merged
Conversation
matlabbe
marked this pull request as ready for review
May 9, 2026 19:29
…ignature is still used in the bayes filter
…des are created and -skip option is not used
… borongyuan-IntermediateNode
…ediate_node_features
…ermediate nodes to keep GUI visualization color working
matlabbe
added a commit
that referenced
this pull request
May 23, 2026
Closed
matlabbe
added a commit
that referenced
this pull request
Jun 7, 2026
…1717) * Fixing empty descriptors on bad signatures (#1714), (bug from #1698) * PyDetector: dont assert (just error) if descriptors/keypoints don't match. SuperPoint approaches: try re-initializing superpoint detection on the provided image if descriptors could not be fetched the first time (auto recover).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support workflow described in #1697 (comment)
Note that if online loop closure detection is disabled, there is no point to create intermediate nodes.
Also, if the goal is to reprocess offline, I would also disable Rehearsal and save all frames. I would simply do a recording session with:
This gives the most flexibility on how we want to reprocess that data offline. In this PR, we also
Kp\MaxFeatures=-1orRtabmap/CreateIntermediateNodes=true, so all VIO data should be saved in the database.