Repository navigation
feat(skill): add avatars and namespace invitations - #947
Merged
Merged
Conversation
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
XiaoSeS
marked this pull request as ready for review
October 12, 2026 06:04
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
XiaoSeS
marked this pull request as draft
October 12, 2026 07:30
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
XiaoSeS
marked this pull request as ready for review
October 12, 2026 09:57
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
FenjuFu
previously requested changes
Oct 13, 2026
FenjuFu
left a comment
Member
There was a problem hiding this comment.
重新核对了当前 d275d1e9(含新的私有临时上传、发布时头像关联及裁剪/缓存修改)。当前公开业务 CI、DCO/CLA 已通过;以下四项仍需要在合并前收敛:
- #910 明确不采用“完全不审核”。
AvatarReviewSettingsService.update仍允许机器/人工两个开关都关闭,当前SkillAvatarAppService.createStoredCandidate在此组合下直接activate头像。请保留至少一种公开头像审核,或先在 issue 中明确并确认变更后的验收约定;文档中的新策略说明不能单独替代原 issue 的验收。 - 候选的审核配置仍只记录供应商和审核开关,复用机器结果仍以图片 SHA、供应商和人工开关为边界,没有记录或匹配审核策略/供应商模型版本。设置本身的乐观并发
version和候选的scopeReviewVersionId(Skill 发布版)不能替代每次审核的策略/模型证据。请持久化可审计的策略及供应商模型/服务版本标识,将其纳入缓存键,并补策略版本改变后不复用旧结果的回归。 - #910 的 Scanner/模型评测与不可变制品供应链仍不在本 PR 的交付范围;#911 仍约定无请求体的一键生成/替换,而现在的创建接口使用
{replace}、活邀请返回 409 要求确认,并提供额外撤销入口。若这些是正式的新产品决策,请同步 issue/API 验收;否则按原约定实现。未完成的原范围先用 Refs 跟踪,避免直接关闭两条 issue。 V69__skill_avatars.sql在当前 head 仍未改号,与 #935 的V69__authoring_platform.sql同号;新增 V71 临时上传表没有消除该冲突。请协调合并顺序,后合分支重新编号并重跑迁移/后端测试。
本次复核基于新旧提交比较、当前 head 的相关完整源码、最新线程和公开 CI;没有独立复跑报告中的全部 PostgreSQL/984 项前端/浏览器场景,也没有调用真实计费供应商接口。
XiaoSeS
marked this pull request as draft
October 13, 2026 10:29
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
XiaoSeS
dismissed
FenjuFu’s stale review
October 14, 2026 10:57
Maintainer authorized dismissal of this outdated review after the reported issues were resolved or explicitly accepted as product scope. Independent source review and local validation completed on the updated head.
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
XiaoSeS
marked this pull request as ready for review
October 14, 2026 12:08
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
处理内容
同一 PR 交付技能头像和团队空间一次性邀请链接。Refs #910. Refs #911.
本轮按维护者在需求讨论中确认的 OpenSpec 方案开发;原 Issue 的 Scanner/开放权重模型评测和模型制品供应链未在本 PR 实现,暂不自动关闭原 Issue。原 Issue 与本轮方案的差异需在合并前取得一致验收约定。
本轮产品边界
/join#invite=<token>,兼容旧裸片段。登录前捕获并清片段,准入与明确确认加入保持;无效新片段不会复用旧暂存邀请。相对原 Issue 的已确认决策
replace=true,另提供单独作废。维护者已明确选择这些交互;与原 Issue 的无确认一键替换有差异。openspec/changes/add-skill-avatars-and-moderation/和openspec/changes/add-namespace-invite-links/,未实现的模型评测/供应链范围继续由原 Issue 跟踪。Review 意见处理
本轮补充
docs/skillhub/guide/skill-avatars.md,已接入中文文档侧栏及发布/审核指南,覆盖讯飞、阿里云、私有配置、Compose、开关与排障。验证状态