Skip to content

fix: horde/whups#21 Wrong date/time format in ticket history #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralflang merged 1 commit into from
Sep 18, 2026
Merged

fix: horde/whups#21 Wrong date/time format in ticket history #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,8 +517,10 @@ protected function _downloadTicket(Variables|Horde_Variables $vars)
);
$time = DateFormat::formatDate(
$transaction['timestamp'],
$prefs->getValue('date_format') . ' '
. $prefs->getValue('time_format')
$prefs->getValue('date_format')
) . ' ' . DateFormat::formatDate(
$transaction['timestamp'],
$prefs->getValue('time_format')
);
echo <<<COMMENT
<table width="100%">
Expand Down
2 changes: 1 addition & 1 deletion lib/Form/Renderer/Comment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ public function render($transaction, $vars)
<div id="t<?php echo (int) $transaction ?>">
<table cellspacing="0" width="100%">
<tr>
<td width="20%" class="<?php echo $class ?>_l nowrap" valign="top"><?php echo DateFormat::formatDate($vars->get('timestamp'), $prefs->getValue('date_format') . ' ' . $prefs->getValue('time_format')) ?></td>
<td width="20%" class="<?php echo $class ?>_l nowrap" valign="top"><?php echo DateFormat::formatDate($vars->get('timestamp'), $prefs->getValue('date_format')) . ' ' . DateFormat::formatDate($vars->get('timestamp'), $prefs->getValue('time_format')) ?></td>
<td width="20%" class="<?php echo $class ?>_m" valign="top"><?php echo $vars->get('user_id') ? Whups::formatUser($vars->get('user_id'), false, true, true) : '&nbsp;' ?></td>
<td width="30%" class="<?php echo $class ?>_m" valign="top"><?php echo implode('<br />', $changes) ?></td>
<td width="30%" class="<?php echo $class ?>_r rightAlign" valign="top"><?php if ($comment && !$private) {
Expand Down
Loading