Repository navigation
fix: horde/whups#21 Wrong date/time format in ticket history - #23
Merged
Merged
Conversation
|
I think when calling DateFormat::formatDate() locale should be set to $GLOBALS['language']. |
Member
Author
|
This would be a step backwards. $GLOBALS['language'] comes from session, prefs or explicitly passed parameter if it is set at all - and increasingly we don't want to set it. So we should have an Injectable (in core) which only resolves language preference in the legacy order and we should use it (in whups) when formatting the date as it might use a language code specific pattern. What we should NOT do is set the locale as the whole point of IntlDateFormatter is locale-independent behaviour even if rendering for a specific language code. |
ralflang
added a commit
that referenced
this pull request
Oct 1, 2026
…rmatters) Adresses #21 Amends #23 Depends on horde/Core#228
ralflang
added a commit
that referenced
this pull request
Oct 2, 2026
…rmatters) Adresses #21 Amends #23 Depends on horde/Core#228
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially Fixes #21