Repository navigation
refactor(themes-catalog): encapsulate reset+register on ThemesHandler - #22
Merged
Merged
Conversation
This was referenced Jul 2, 2026
ralflang
added a commit
that referenced
this pull request
Jul 4, 2026
Release version 3.6.1-RC3 Merge pull request #22 from horde/fix/themes-catalog-followup Merge pull request #27 from Bramvzw/chore/drop-invalid-function-use-imports chore: drop invalid class-style use imports for global functions refactor(themes-catalog): encapsulate reset+register on ThemesHandler fix(themes-catalog): rebuild themes.json from scratch on each reconfigure run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #21.
Summary
Reconfigure flow no longer reaches through the public
$themesCatalogproperty: addsThemesHandler::resetCatalog()andregisterTheme()as thin delegators. Strips trailing whitespace introduced in #21 (only cs-fixer violation on the file). Flags the never-wiredThemesCatalog::unregister()stub as@deprecated. AddsThemesCatalogTest— 3 tests, 12 assertions — covering the reset+register cycle in memory and on disk (the exact regression #21 fixed).