Repository navigation
Piper: stream ingress uploads to allow voices larger than 16 MiB - #4912
WhoCares1337 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Hi @WhoCares1337, the code for the app your PR was targeting was migrated to home-assistant/app-piper. Please submit a new PR there. Please leave out the version bump and the CHANGELOG.md entry. The version now comes from the GitHub release, and the PR title goes into the release notes. Thank you! |
|
Thanks @sairon! Resubmitted to home-assistant/app-piper as home-assistant/app-piper#3, without the version bump and changelog entry. |
Uploading a custom voice through the Piper web UI fails with HTTP 413 for any file over 16 MiB, which covers nearly every medium-quality voice (~60 MB). The Supervisor reads non-streamed ingress bodies with aiohttp's
client_max_size(16 MiB). Withingress_stream: true, POST bodies are passed on as a stream, and that limit doesn't apply (supervisor/api/ingress.py). The web UI (Flask/Werkzeug) handles the chunked body without problems.Tested on HA OS with a local copy of the add-on with
ingress_stream: true: a 60.6 MB voice uploaded successfully, where 2.5.2 returns 413.Fixes home-assistant/supervisor#7381
Summary by CodeRabbit