Repository navigation
Piper: stream ingress uploads to allow voices larger than 16 MiB - #3
Open
WhoCares1337 wants to merge 1 commit into
Open
WhoCares1337 wants to merge 1 commit into
WhoCares1337 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uploading a custom voice through the Piper web UI fails with HTTP 413 for any file over 16 MiB, which covers nearly every medium-quality voice (~60 MB). The Supervisor reads non-streamed ingress bodies with aiohttp's
client_max_size(16 MiB). Withingress_stream: true, POST bodies are passed on as a stream, and that limit doesn't apply (supervisor/api/ingress.py). The web UI (Flask/Werkzeug) handles the chunked body without problems.Tested on HA OS with a local copy of the app with
ingress_stream: true: a 60.6 MB voice uploaded successfully, where 2.5.2 returns 413.Resubmitted from home-assistant/apps#4912.
Fixes home-assistant/supervisor#7381